Skip to content

Commit

Permalink
deprecate all pyfontaine checks
Browse files Browse the repository at this point in the history
and remove all pyfontaine and pyicu from dependencies and documentation.
(issue fonttools#1537)
  • Loading branch information
felipesanches committed Aug 22, 2017
1 parent 0674735 commit 3756055
Show file tree
Hide file tree
Showing 6 changed files with 28 additions and 13 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
* 0.3.2 (2017-Aug-??):
- fix crash on fontbakery-check-font-version.py
- add automated tests for the fixer scripts
- deprecated pyfontaine tests (132 to 151)

* 0.3.1 (2017-Aug-11):
- Emergencial release to address broken 0.3.0 packaging.
Expand Down
1 change: 0 additions & 1 deletion DESIGN_CONSIDERATIONS.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ Steps below can be ignored if you use `fontbakery-travis-init.py` script. It get
- sudo make install
- cd ..
install:
- pip install pyicu
- pip install git+https://github.com/behdad/fontTools.git
- pip install git+https://github.com/googlefonts/fontcrunch.git
- pip install git+https://github.com/googlefonts/fontbakery.git
Expand Down
28 changes: 27 additions & 1 deletion Lib/fontbakery/specifications/googlefonts_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -1207,7 +1207,7 @@ def test_id_068():
status, message = list(check_fullfontname_begins_with_the_font_familyname(ttFont))[-1]
assert status == FAIL and message.code == "no-font-family-name"

# TODO: test_id_069
# TODO: tests 069 to 108

def test_id_102():
""" Copyright notice matches canonical pattern ? """
Expand All @@ -1232,6 +1232,7 @@ def test_id_102():
status, message = list(check_Copyright_notice_matches_canonical_pattern(font_meta))[-1]
assert status == PASS

# TODO: tests 103 to 108

def test_id_109():
""" Check if fontname is not camel cased. """
Expand Down Expand Up @@ -1287,6 +1288,31 @@ def test_id_110():
status, message = list(check_font_name_is_the_same_as_family_name(family_meta, font_meta))[-1]
assert status == FAIL

# TODO: tests 111 to 131

# DEPRECATED CHECKS:
# com.google.fonts/test/132 - "Checking Cyrillic Historical glyph coverage."
# com.google.fonts/test/133 - "Checking Google Cyrillic Plus glyph coverage."
# com.google.fonts/test/134 - "Checking Google Cyrillic Plus (Localized Forms) glyph coverage."
# com.google.fonts/test/135 - "Checking Google Cyrillic Pro glyph coverage."
# com.google.fonts/test/136 - "Checking Google Greek Ancient Musical Symbols glyph coverage."
# com.google.fonts/test/137 - "Checking Google Greek Archaic glyph coverage."
# com.google.fonts/test/138 - "Checking Google Greek Coptic glyph coverage."
# com.google.fonts/test/139 - "Checking Google Greek Core glyph coverage."
# com.google.fonts/test/140 - "Checking Google Greek Expert glyph coverage."
# com.google.fonts/test/141 - "Checking Google Greek Plus glyph coverage."
# com.google.fonts/test/142 - "Checking Google Greek Pro glyph coverage."
# com.google.fonts/test/143 - "Checking Google Latin Core glyph coverage."
# com.google.fonts/test/144 - "Checking Google Latin Expert glyph coverage."
# com.google.fonts/test/145 - "Checking Google Latin Plus glyph coverage."
# com.google.fonts/test/146 - "Checking Google Latin Plus (Optional Glyphs) glyph coverage."
# com.google.fonts/test/147 - "Checking Google Latin Pro glyph coverage."
# com.google.fonts/test/148 - "Checking Google Latin Pro (Optional Glyphs) glyph coverage."
# com.google.fonts/test/149 - "Checking Google Arabic glyph coverage."
# com.google.fonts/test/150 - "Checking Google Vietnamese glyph coverage."
# com.google.fonts/test/151 - "Checking Google Extras glyph coverage."

# TODO: test_id_152

def test_id_153(montserrat_ttFonts):
"""Check glyphs contain the recommended contour count"""
Expand Down
9 changes: 0 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -612,10 +612,6 @@ pip install --upgrade git+https://github.com/behdad/fontTools.git;
# install python dependencies
pip install -r requirements.txt

# install pyfontaine
CFLAGS=-I/usr/local/opt/icu4c/include LDFLAGS=-L/usr/local/opt/icu4c/lib pip install pyicu;
pip install --upgrade git+https://github.com/davelab6/pyfontaine.git;

# install travis, for setting up CI
sudo gem install travis; # fontbakery dependencies

Expand All @@ -631,11 +627,6 @@ sudo add-apt-repository --yes ppa:fontforge/fontforge;
sudo apt-get update -qq;
sudo apt-get install python-fontforge

# install pyfontaine
sudo apt-get install libicu-dev git;
sudo pip install pyicu;
pip install --upgrade git+https://github.com/davelab6/pyfontaine.git;

# install ots from source
git clone https://github.com/khaledhosny/ots.git;
cd ots;
Expand Down
1 change: 0 additions & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,4 @@ Unidecode==0.4.19
wheel==0.24.0
GitPython==0.3.2rc1
python-dateutil
pyicu
pytest
1 change: 0 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,6 @@ def normalize_path(path, seperator='/'):
'lxml',
'requests',
'pyyaml',
'fontaine',
'html5lib',
'python-magic',
'markdown',
Expand Down

0 comments on commit 3756055

Please sign in to comment.