-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate all pyfontaine tests #1537
Comments
I had an idea recently to make this generally better:
|
To worst thing about the pyfontaine checks is that most of them fail by default. The above would regulate that. Also, once a font is released we should know which encodings are supported. The above adds a nice regression detection. |
I think we should turn pyfontaine off completely for now, it is a standalone tool and plugging into it quickly was just a stop gap. The real need for now is to implement #1466 |
and remove all pyfontaine and pyicu from dependencies and documentation. (issue fonttools#1537)
In
check-ttf
we had the--no-coverage
flag to disable pyfontaine, #1345. This came about because the implementation was was too slow.I don't want to disable pyfontaine, I just want cleaner output.
The current output is very bad for QAing families containing many styles.
The check is run several times on each font for different codepages. If I save a log, pyfontaine error messages make up over 80%. It makes FB almost impossible to use.
The text was updated successfully, but these errors were encountered: