Skip to content

Commit

Permalink
do not mix ttf-specific check results in the webapp tabs
Browse files Browse the repository at this point in the history
This  is fixed by reseting the check results logger object after outputing each individual report, so that it avoinds accumulating the previous messages.
(issues fonttools#1133 & fonttools#1121)
  • Loading branch information
felipesanches committed Oct 27, 2016
1 parent ca5d421 commit d3ce504
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions fontbakery-check-ttf.py
Original file line number Diff line number Diff line change
Expand Up @@ -3767,6 +3767,7 @@ def is_italic():
fb.ok("Font em size is equal to 1000.")

fb.output_report(font_file)
fb.reset_report()

if not webapp:
# ----------------------------------------------------
Expand All @@ -3782,8 +3783,6 @@ def is_italic():
logging.info("{} saved\n".format(font_file_output))
font.close()

fb.reset_report()

# -------------------------------------------------------
if not config['verbose'] and \
not config['json'] and \
Expand All @@ -3800,8 +3799,6 @@ def is_italic():
" --ghm \tSave results to a file in GitHub Markdown format.\n"
" --error\tPrint only the error messages (outputs to stderr).\n")



if webapp:
return ghm_report_files
else:
Expand Down

0 comments on commit d3ce504

Please sign in to comment.