Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webapp: individual ttf check results are getting mixed together in the tabs #1133

Closed
felipesanches opened this issue Oct 26, 2016 · 2 comments
Closed

webapp: individual ttf check results are getting mixed together in the tabs #1133

felipesanches opened this issue Oct 26, 2016 · 2 comments
Assignees
@felipesanches
Labels
P0 Urgent
Milestone
0.2.0 Binary Chec...

Comments

@felipesanches
Copy link
Collaborator

Expected behaviour

Each TTF-specific tab should display only the error messages related to that single file

Observed behaviour

The first tab looks good. The second tab displays the correct content but also displays all of the results from the previous tab. And so on, until the last tab which displays all log messages of all tested files. It seems that we're gradualy concatenating the check results.
@felipesanches felipesanches self-assigned this Oct 26, 2016
@felipesanches
Copy link
Collaborator Author

I'll fix this by reseting the check results logger object after outputing each individual report, so that it avoinds accumulating the previous messages.

felipesanches added a commit to felipesanches/fontbakery that referenced this issue Oct 26, 2016
@felipesanches
do not mix ttf-specific check results in the webapp tabs
6f5c9d7 
This  is fixed by reseting the check results logger object after outputing each individual report, so that it avoinds accumulating the previous messages.
(issues fonttools#1133 & fonttools#1121)
@felipesanches
Copy link
Collaborator Author

implemented on branch issue_1121 will be merged with the rest of the webapp code tracked by issue #1121

@felipesanches felipesanches added this to the 0.2.0 milestone Oct 27, 2016
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Oct 27, 2016
@felipesanches
do not mix ttf-specific check results in the webapp tabs
ba04ea5 
This  is fixed by reseting the check results logger object after outputing each individual report, so that it avoinds accumulating the previous messages.
(issues fonttools#1133 & fonttools#1121)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Oct 27, 2016
@felipesanches
do not mix ttf-specific check results in the webapp tabs
d3ce504 
This  is fixed by reseting the check results logger object after outputing each individual report, so that it avoinds accumulating the previous messages.
(issues fonttools#1133 & fonttools#1121)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipesanches felipesanches

Labels
P0 Urgent
Projects
None yet
Milestone
0.2.0 Binary Checks Are Reliable
Development

No branches or pull requests
1 participant
@felipesanches