fix some HUB related issues #414
Conversation
ardi69
commented
Oct 11, 2018
ardi69
commented
- fix Issue The HID device is not recognized through the USB hub. #334 in USB::AttemptConfig on failure the device is not correctly reseted because devConfig[parent] does not the right thing. Added function USB::ResetHubPort dues the job.
- is a HUB is unplugged from a parent HUB the unplugged HUB is not released.
- is a HUB released its childs are not released
|
Re #334 will test later today. Thank you! |
|
i have forgotten: insert in usbhub.h |
|
@xxxajk did you ever test this? |
|
@xxxajk ping? |
|
Pong! will check today. Been overloaded with work... |
|
PR #414 fixes problems I had with hub + USB mouse + USB keyboard using the hub_demo example. Looks fine. The USBHIDBootKbdAndMouse example also works fine. Moving mouse and pressing keys results in serial console output as expected. I will see if the same fixes apply to the SAMD port. |
| UsbDeviceAddress a; | ||
| a.devAddress = bAddress; | ||
| a.bmHub = 0; | ||
| a.bmAddress = port ? : 1; |
There was a problem hiding this comment.
Not sure what this does when port is non-zero. Is it the equivalent of
if (port) {
a.bmAddress = ;
} else {
a.bmAddress = 1;
}
There was a problem hiding this comment.
Yes. Port numbers start at 1.
Right now commits are stopped, but eventually should be resumed.
| } else { | ||
| for(uint8_t i = 0; i < USB_NUMDEVICES; i++) { | ||
| if(!devConfig[i]) continue; | ||
| if(devConfig[i]->GetPortAddress() == addr) |
There was a problem hiding this comment.
I think this would be better to replace this with:
if((a.bmHub && devConfig[i]->GetAddress() == addr) || (!a.bmHub && devConfig[i]->GetPortAddress() == addr))And then get rid of the if(a.bmHub) if-statement above.
| virtual uint8_t GetPortAddress() { | ||
| return GetAddress(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Please fix the indentation here.
| return bPortAddress; | ||
| }; | ||
|
|
||
| virtual bool DEVCLASSOK(uint8_t klass) { |
There was a problem hiding this comment.
Please also fix indentation here.
