Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting crashed #445

Closed
mberneis opened this issue Jul 26, 2017 · 0 comments · Fixed by #504
Closed

Formatting crashed #445

mberneis opened this issue Jul 26, 2017 · 0 comments · Fixed by #504
Labels
formatting

Comments

@mberneis
Copy link

mberneis commented Jul 26, 2017 •
edited

Other files in my project format correctly, just this one crashes

  Message: Exception: Unable to format file in /Users/mberneis/.vscode/extensions/felixfbecker.php-intellisense-1.4.3/vendor/felixfbecker/language-server/src/Formatter.php:52
Stack trace:
#0 /Users/mberneis/.vscode/extensions/felixfbecker.php-intellisense-1.4.3/vendor/felixfbecker/language-server/src/PhpDocument.php(179): LanguageServer\Formatter::format('<?php\ndefined('...', 'file:///Users/m...')
#1 /Users/mberneis/.vscode/extensions/felixfbecker.php-intellisense-1.4.3/vendor/felixfbecker/language-server/src/Server/TextDocument.php(172): LanguageServer\PhpDocument->getFormattedText()
#2 /Users/mberneis/.vscode/extensions/felixfbecker.php-intellisense-1.4.3/vendor/sabre/event/lib/Promise.php(242): LanguageServer\Server\TextDocument->LanguageServer\Server\{closure}(Object(LanguageServer\PhpDocument))
#3 /Users/mberneis/.vscode/extensions/felixfbecker.php-intellisense-1.4.3/vendor/sabre/event/lib/Loop/Loop.php(261): Sabre\Event\Promise->Sabre\Event\{closure}()
#4 /Users/mberneis/.vscode/extensions/felixfbecker.php-intellisense-1.4.3/vendor/sabre/event/lib/Loop/Loop.php(215): Sabre\Event\Loop\Loop->runNextTicks()
#5 /Users/mberneis/.vscode/extensions/felixfbecker.php-intellisense-1.4.3/vendor/sabre/event/lib/Loop/Loop.php(194): Sabre\Event\Loop\Loop->tick(true)
#6 /Users/mberneis/.vscode/extensions/felixfbecker.php-intellisense-1.4.3/vendor/sabre/event/lib/Loop/functions.php(122): Sabre\Event\Loop\Loop->run()
#7 /Users/mberneis/.vscode/extensions/felixfbecker.php-intellisense-1.4.3/vendor/felixfbecker/language-server/bin/php-language-server.php(102): Sabre\Event\Loop\run()
#8 {main}
  Code: -32603
@felixfbecker felixfbecker mentioned this issue Sep 11, 2017
Closed
felixfbecker added a commit that referenced this issue Oct 28, 2017
@felixfbecker
fix(formatting): drop PHP CodeSniffer
1b0ef42 
BREAKING CHANGE: removes formatting support

closes #501
closes #474
closes #473
closes #468
closes #450
closes #445
closes #443
closes #423
closes #343
closes #296
closes #293
@felixfbecker felixfbecker mentioned this issue Oct 28, 2017
Merged
felixfbecker added a commit that referenced this issue Oct 28, 2017
@felixfbecker
fix(formatting): drop PHP CodeSniffer
02ebde3 
BREAKING CHANGE: removes formatting support

closes #501
closes #474
closes #473
closes #468
closes #450
closes #445
closes #443
closes #423
closes #343
closes #296
closes #293
closes #499
closes #471
felixfbecker added a commit that referenced this issue Oct 28, 2017
@felixfbecker
fix(formatting): drop PHP CodeSniffer
648dd25 
BREAKING CHANGE: removes formatting support

closes #501
closes #474
closes #473
closes #468
closes #450
closes #445
closes #443
closes #423
closes #343
closes #296
closes #293
closes #499
closes #471
felixfbecker added a commit that referenced this issue Oct 28, 2017
@felixfbecker
fix(formatting): drop PHP CodeSniffer
326c9a2 
BREAKING CHANGE: removes formatting support

closes #501
closes #474
closes #473
closes #468
closes #450
closes #445
closes #443
closes #423
closes #343
closes #296
closes #293
closes #499
closes #471
felixfbecker added a commit that referenced this issue Oct 28, 2017
@felixfbecker
fix(formatting): drop PHP CodeSniffer
4b81c33 
BREAKING CHANGE: removes formatting support

closes #501
closes #474
closes #473
closes #468
closes #450
closes #445
closes #443
closes #423
closes #343
closes #296
closes #293
closes #499
closes #471
felixfbecker added a commit that referenced this issue Nov 5, 2017
@felixfbecker
fix(formatting): drop PHP CodeSniffer (#504)
f00fd1b 
At this point there are countless issues about the formatting done by CodeSniffer. It plain out doesn't work in many cases, overrides format options that are contributed by other extensions in VS Code and does not reuse any of our AST parsing. For that reason, I am starting to think there is no reason to keep it in here until we have proper pretty-printing support from https://github.com/Microsoft/tolerant-php-parser that actually reuses our ASTs and can work while editing. For people who want to use CodeSniffer to format their code, there could be a standalone CodeSniffer language server (like there is a TSLint language server and ESLint language server). As said, we don't reuse our state anyway.

BREAKING CHANGE: removes formatting support

closes #501
closes #474
closes #473
closes #468
closes #450
closes #445
closes #443
closes #423
closes #343
closes #296
closes #293
closes #499
closes #471
@dependencies dependencies bot mentioned this issue Nov 5, 2017
Closed
cgxxv pushed a commit to cgxxv/php-language-server that referenced this issue Mar 25, 2022
@felixfbecker
fix(formatting): drop PHP CodeSniffer (felixfbecker#504)
0845a16 
At this point there are countless issues about the formatting done by CodeSniffer. It plain out doesn't work in many cases, overrides format options that are contributed by other extensions in VS Code and does not reuse any of our AST parsing. For that reason, I am starting to think there is no reason to keep it in here until we have proper pretty-printing support from https://github.com/Microsoft/tolerant-php-parser that actually reuses our ASTs and can work while editing. For people who want to use CodeSniffer to format their code, there could be a standalone CodeSniffer language server (like there is a TSLint language server and ESLint language server). As said, we don't reuse our state anyway.

BREAKING CHANGE: removes formatting support

closes felixfbecker#501
closes felixfbecker#474
closes felixfbecker#473
closes felixfbecker#468
closes felixfbecker#450
closes felixfbecker#445
closes felixfbecker#443
closes felixfbecker#423
closes felixfbecker#343
closes felixfbecker#296
closes felixfbecker#293
closes felixfbecker#499
closes felixfbecker#471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
formatting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(formatting): drop PHP CodeSniffer felixfbecker/php-language-server
2 participants
@mberneis @felixfbecker