Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update composer.json php codesniffer #471

Closed
wants to merge 2 commits into from

Conversation

allan-simon
Copy link

it has been released in 3.0.X as stable

it has been released in 3.0.X as stable
@felixfbecker
Copy link
Owner

Build's broken. There was a problem with the CodeSniffer 3 autoloader. If you can fix that, happy to upgrade

@allan-simon
Copy link
Author

hmmm it seems to be because of this change in php code sniffer squizlabs/PHP_CodeSniffer@566a0cd#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780L27 :(

@raul338
Copy link

raul338 commented Sep 28, 2017

You can create a tests/bootstrap.php file and include the autoload there

<?php
require __DIR__ . '/../vendor/autoload.php';
require __DIR__ . '/../vendor/squizlabs/php_codesniffer/autoload.php';

@felixfbecker
Copy link
Owner

That would fix it for tests, but does it fix it at runtime?

@raul338
Copy link

raul338 commented Sep 28, 2017

Can't really tell right now, I'm trying to debug vscode-php-intellisense, after the symlink and press F5 throws an error:

Here is the error stack:  /home/raul/test/vscode-php-intellisense/node_modules/vscode-languageclient/lib/main.js:916
        return this.resolveConnection().theconnection => {
               ^^^^

I cloned the master branch

@felixfbecker
Copy link
Owner

That's not a very helpful error stack. Do you have the right version of Node? Did you run npm install?

@raul338
Copy link

raul338 commented Sep 29, 2017

I didn't see an error that npm run build throws

> php-intellisense@1.5.1 build /home/raul/test/vscode-php-intellisense
> tsc -p .

node_modules/vscode-languageclient/lib/client.d.ts(1,706): error TS2305: Module ''vscode'' has no exported member 'WorkspaceFolder'.
node_modules/vscode-languageclient/lib/workspaceFolders.proposed.d.ts(1,10): error TS2305: Module ''vscode'' has no exported member 'WorkspaceFoldersChangeEvent'.

I'll keep trying...

EDIT: It was a corrupted install, nuked node_modules folders, reinstall and buid ok. It works

felixfbecker added a commit that referenced this pull request Oct 28, 2017
BREAKING CHANGE: removes formatting support

closes #501
closes #474
closes #473
closes #468
closes #450
closes #445
closes #443
closes #423
closes #343
closes #296
closes #293
closes #499
closes #471
felixfbecker added a commit that referenced this pull request Oct 28, 2017
BREAKING CHANGE: removes formatting support

closes #501
closes #474
closes #473
closes #468
closes #450
closes #445
closes #443
closes #423
closes #343
closes #296
closes #293
closes #499
closes #471
felixfbecker added a commit that referenced this pull request Oct 28, 2017
BREAKING CHANGE: removes formatting support

closes #501
closes #474
closes #473
closes #468
closes #450
closes #445
closes #443
closes #423
closes #343
closes #296
closes #293
closes #499
closes #471
felixfbecker added a commit that referenced this pull request Oct 28, 2017
BREAKING CHANGE: removes formatting support

closes #501
closes #474
closes #473
closes #468
closes #450
closes #445
closes #443
closes #423
closes #343
closes #296
closes #293
closes #499
closes #471
cgxxv pushed a commit to cgxxv/php-language-server that referenced this pull request Mar 25, 2022
At this point there are countless issues about the formatting done by CodeSniffer. It plain out doesn't work in many cases, overrides format options that are contributed by other extensions in VS Code and does not reuse any of our AST parsing. For that reason, I am starting to think there is no reason to keep it in here until we have proper pretty-printing support from https://github.com/Microsoft/tolerant-php-parser that actually reuses our ASTs and can work while editing. For people who want to use CodeSniffer to format their code, there could be a standalone CodeSniffer language server (like there is a TSLint language server and ESLint language server). As said, we don't reuse our state anyway.

BREAKING CHANGE: removes formatting support

closes felixfbecker#501
closes felixfbecker#474
closes felixfbecker#473
closes felixfbecker#468
closes felixfbecker#450
closes felixfbecker#445
closes felixfbecker#443
closes felixfbecker#423
closes felixfbecker#343
closes felixfbecker#296
closes felixfbecker#293
closes felixfbecker#499
closes felixfbecker#471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants