References #52
Merged
References #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 92.38% (diff: 96.58%)@@ master #52 diff @@
==========================================
Files 24 26 +2
Lines 508 591 +83
Methods 73 83 +10
Messages 0 0
Branches 0 0
==========================================
+ Hits 464 546 +82
- Misses 44 45 +1
Partials 0 0
|
felixfbecker
force-pushed
the
references
branch
9 times, most recently
from
3357f52
to
9369701
Compare
felixfbecker
force-pushed
the
references
branch
from
0f05969
to
e93531d
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20
Adds support for
textDocument/references. At index time in addition to definitions, also a map of FQN to array of referencing document URIs is kept.Just like definition, it works very well for class-likes, functions and constants, but not so great for methods and properties where it is hard to infer the class. Variables and parameters also work surprisingly well.
ToDo