feat: Support private registry host #28
Conversation
* feat: Support login to private registry * chore: Prettify lib/verify.js * fix: Use DOCKER_REGISTRY instead of DOCKER_HOST to avoid conflict
|
@felixfbecker Thank you for this package. Is there anything I can do to make this pull request able to be merged? |
* feat: Support login to private registry * chore: Prettify lib/verify.js * fix: Use DOCKER_REGISTRY instead of DOCKER_HOST to avoid conflict * fix: Switch registry URL to config * fix: Change capitalization of config to match other configs * chore: Make documentation for registryUrl more specific
|
+1 |
|
@felixfbecker Do the changes here work for you? Or do you have any additional feedback I can address? |
README.md
Outdated
| @@ -27,9 +30,9 @@ Set of [semantic-release](https://github.com/semantic-release/semantic-release) | |||
|
|
|||
| ## Configuration | |||
|
|
|||
| Your credentials have to be configured with the environment variables `DOCKER_USERNAME` and `DOCKER_PASSWORD`. | |||
| Your credentials have to be configured with the environment variables `DOCKER_USERNAME` and `DOCKER_PASSWORD`. If you are using a private docker registry, set its URL in the environment variable `DOCKER_REGISTRY`. | |||
There was a problem hiding this comment.
This is not correct anymore, right?
There was a problem hiding this comment.
I think it still is. I looked at the beta api of semantic-release plugins and it seems unchanged. But a lof of things have been added to the beta release (channels etc.).
There was a problem hiding this comment.
I meant the DOCKER_REGISTRY env var, I don’t see that used anymore
There was a problem hiding this comment.
@felixfbecker Oops. You are correct. I forgot to take out the old change to the docs when I put in the new one. I just fixed that.
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This pull request adds support for non-default docker hosts (such as self-hosted registries or services like Amazon ECR). It introduces an optional environment variable DOCKER_REGISTRY to denote the URL of the registry. If this variable is left blank, the default registry of the docker client (probably Docker Hub) will be used.
This pull request adds support for non-default docker hosts (such as self-hosted registries or services like Amazon ECR). It introduces an optional environment variable DOCKER_REGISTRY to denote the URL of the registry. If this variable is left blank, the default registry of the docker client (probably Docker Hub) will be used.