Replace fmt.Sscanf with strconv.Atoi for faster int conversion

felixge · Sep 27, 2020 · 2bee013 · 2bee013
1 parent 5aa20cb
commit 2bee013
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/handler.go b/handler.go
@@ -3,6 +3,7 @@ package fgprof
 import (
 	"fmt"
 	"net/http"
+	"strconv"
 	"time"
 )
 
@@ -15,7 +16,7 @@ func Handler() http.Handler {
 		var seconds int
 		if s := r.URL.Query().Get("seconds"); s == "" {
 			seconds = 30
-		} else if _, err := fmt.Sscanf(s, "%d", &seconds); err != nil || seconds <= 0 {
+		} else if seconds, err := strconv.Atoi(s); err != nil || seconds <= 0 {
 			w.WriteHeader(http.StatusBadRequest)
 			fmt.Fprintf(w, "bad seconds: %d: %s\n", seconds, err)
 		}