Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source code instrumentation support for the 'blanket' coverage tool #28

Closed
wants to merge 2 commits into from
Closed

Conversation

lovell
Copy link

@lovell lovell commented Jan 8, 2014

Hello,

I've added support for Alex Seville's blanket code coverage library, very much in the vein of the existing istanbul code coverage support.

There's a fairly simple unit test that verifies the state of the baz test fixture source code both before and after adding instrumentation.

I also removed Node.js versions 0.6 and earlier from the Travis CI job as these are no longer supported - npm/npm#4379 provides more details.

Cheers,
Lovell

- 0.8
- 0.9
- 0.10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not going to remove support for these Node versions!

@domenic
Copy link
Collaborator

domenic commented Jan 8, 2014

Can't you just publish a separate source transformer and instruct people to use that?

@searls
Copy link
Collaborator

searls commented Jan 8, 2014

Agreed. The goal of the source transformer meme was to make it possible / easy for others to publish their own interceptors without requiring changes to this module itself. 

Not because your plugin is any less valuable, but to avoid the maintenance risk posed by a bunch of—for existing users—unnecessary additions.

On Wed, Jan 8, 2014 at 11:11 AM, Domenic Denicola
notifications@github.com wrote:

Can't you just publish a separate source transformer and instruct people to use that?

Reply to this email directly or view it on GitHub:
#28 (comment)

@lovell
Copy link
Author

lovell commented Jan 8, 2014

No probs, I'm happy to publish this as its own module. Thanks both for your swift replies.

@lovell lovell closed this Jan 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants