Moar unit tests, better code

felixge · Nov 14, 2011 · b3e479f · b3e479f
1 parent 4dd62f2
commit b3e479f
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/lib/FileRunner.js b/lib/FileRunner.js
@@ -32,10 +32,15 @@ FileRunner.prototype._capture = function(stream) {
 FileRunner.prototype._errorFor = function(code, signal) {
     if (!code && !signal) return;
 
-    var path = this._file;
-    if (path.indexOf(this._cwd) === 0) path = path.substr(this._cwd.length + 1);
-    var prefix = 'node ' + path + ' died with ';
+    var prefix = 'node ' + this.relativePath() + ' died with ';
 
     if (code) return new Error(prefix + 'code: ' + code);
     if (signal) return new Error(prefix + 'signal: ' + signal);
 };
+
+FileRunner.prototype.relativePath = function() {
+  var path = this._file;
+  return (path.indexOf(this._cwd) === 0)
+    ? path = path.substr(this._cwd.length + 1)
+    : path;
+};
diff --git a/test/unit/test-FileRunner.js b/test/unit/test-FileRunner.js
@@ -0,0 +1,10 @@
+var test       = require('utest');
+var assert     = require('assert');
+var FileRunner = require('../../lib/FileRunner');
+
+test('FileRunner', {
+  'relativePath': function() {
+    var runner = new FileRunner({file: '/a/b/c', cwd: '/a'});
+    assert.equal(runner.relativePath(), 'b/c');
+  },
+});