Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make download link stable #430

Closed
linonetwo opened this issue Oct 23, 2022 · 6 comments
Closed

Make download link stable #430

linonetwo opened this issue Oct 23, 2022 · 6 comments

Comments

@linonetwo
Copy link

Like  https://github.com/felixhayashi/TW5-TiddlyMap/releases/latest/download/tiddlymap.json 

So we can automatically fetch latest release in Community plugin library https://github.com/tiddly-gittly/TiddlyWiki-CPL

Like my plugins' link https://github.com/tiddly-gittly/tiddlywiki-plugins/releases/latest/download/24.3A.2Fplugins.2Flinonetwo.2Fsmart-field.json

@flibbles
Copy link
Collaborator

Interesting idea. A few questions:

  • How does this work given that TiddlyMap has three dependencies. I only control one of them, and I'm sure the other two are not configured the way you describe.
  • How is Relink in the CPL list when I never configured it the way you describe.
  • Why aren't my other awesome plugins, like Uglify, not there? Who's deciding what plugins go in?

@linonetwo
Copy link
Author

Well, acturally we can extrace plugins from the HTML, the vis.js plugin is extracted directly from http://tiddlymap.org/index.html but this can be slow, and plugin in that HTML may not be updated.

So we hope all plugins can provide a json format.

For Relink, I personally use Relink library. But some community members may add plugins to CPL at their will, because they think installing/upgrading everything in a single library is comfortable. It is added by some random member. (but will be recorded in the git commit message) So they add plugins they are using to it, and enjoy one-click-upgrade.

You can clone the repo and add tiddler like https://github.com/tiddly-gittly/TiddlyWiki-CPL/blob/master/tiddlers/Plugin_202203225931551.json or https://github.com/tiddly-gittly/TiddlyWiki-CPL/blob/master/tiddlers/linonetwo_commandpalette.json

Then your plugins will be added.

flibbles added a commit that referenced this issue Oct 29, 2022
Maybe felix will disagree with this decision, but people are asking for
a stable link to the bundle, and providing it through github's release
feature is the best way to do that, moreso than through an actual
repository directory.

I'm removing the version number from the generated source to create
a stable download link for #430.
@flibbles
Copy link
Collaborator

Okay. I think I've done this correctly. Your stable download link should be this:

https://github.com/felixhayashi/TW5-TiddlyMap/releases/latest/download/tiddlymap.json

I'll close this issue, but if that isn't correct, let me know and reopen. This is the first time I've set this up.

@flibbles
Copy link
Collaborator

For real though. Did I get it right? I'm noticing that the json file I produced has the plugin wrapped in a JSON array, and yours doesn't. Does that matter?

@linonetwo
Copy link
Author

linonetwo commented Oct 30, 2022

Yes, it worked, thanks. As long as it is a valid tid that can be loaded by tiddlywiki.

截屏2022-10-30 13 56 38

@linonetwo
Copy link
Author

I also copy the readme of this repo to it, as in the screenshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants