Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix V8 for Electron 7 #2

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Fix V8 for Electron 7 #2

merged 1 commit into from
Nov 12, 2019

Conversation

fxha
Copy link

@fxha fxha commented Oct 26, 2019

Replaced deprecated V8 methods.

mjurkowski
mjurkowski approved these changes Oct 28, 2019
View reviewed changes
Copy link

@mjurkowski mjurkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@fxha fxha mentioned this pull request Oct 28, 2019
Closed
@tommoor
Copy link

tommoor commented Oct 31, 2019

Electron 7 is now in production, would love to see this released so apps depending on electron-spellchecker can upgrade

@felixrieseberg felixrieseberg merged commit bf829b3 into felixrieseberg:felix-hunspell-only Nov 12, 2019
@felixrieseberg
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjurkowski mjurkowski mjurkowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@fxha @tommoor @felixrieseberg @mjurkowski