Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab scrollbar overlaps tabs #35

Closed
hanskokx opened this issue Jun 4, 2018 · 3 comments
Closed

Tab scrollbar overlaps tabs #35

hanskokx opened this issue Jun 4, 2018 · 3 comments
Labels
bug Something isn't working Fixed in next release This is already fixed and will be included in the next release help wanted Extra attention is needed

Comments

@hanskokx
Copy link
Contributor

hanskokx commented Jun 4, 2018

image

@felixse
Copy link
Owner

felixse commented Jun 4, 2018

Yeah, I knew this will come up eventually 😄

I guess we need a custom template for the scrollviewer here, tried it once but didn't get it to scroll correctly.

I will give this another try once we have to more important issues solved, but I would also be more than happy if some XAML hero wants to have a try on this.

@felixse felixse added bug Something isn't working help wanted Extra attention is needed labels Jun 4, 2018
@hanskokx
Copy link
Contributor Author

hanskokx commented Jun 4, 2018 via email

@felixse
Copy link
Owner

felixse commented Jun 4, 2018

Yeah, thats what I tried to implement, but didn't get the buttons to actually scroll.

I don't think it's impossible, just needs more than I was willing to invest when I tried

@felixse felixse reopened this Jul 8, 2018
@felixse felixse added the Fixed in next release This is already fixed and will be included in the next release label Jul 8, 2018
@felixse felixse closed this as completed Jul 19, 2018
mjs pushed a commit to mjs/FluentTerminal that referenced this issue Apr 23, 2019
felixse pushed a commit that referenced this issue May 10, 2019
* Implementing SSH (changes from ap/ssh branch).

* Implemented opening links in the last active window.

* Using settings to determine where to open link (tab or window).

* Adding FluentTerminal.App_TemporaryKey.pfx back to repo, to solve bug with keys.

* App activation on mosh schema launching; mosh protocol parsing. (#35)

* SSH handling changed to improve links.

* Creating shortcuts from SSH dialog.

* Trivial Mosh checkbox label fix

It's "Mosh" not "MOSH".

* Obtain mosh key from ssh connection (#40)

* Prepopulate SSH username with Windows username (#50)

* Undoing Max's mosh authentication changes.

* Adding the new mosh wrapper.

* Request user name from tray process (#51)

* Mosh implemented, but still doesn't work (cannot find mosh.exe).

*  Add New Remote Shell menu; Rename New Tab into New Local Shell (#52)

* Mosh works like charm.

* Mosh wrapper improved to print an error.

* Changing mosh wrapper to always exit with 0 (to ensure that the tab gets closed).

* Changing mosh wrapper again to return error codes.

* Slightly optimizing getting the username.

* Saving links improved.

* Fixed an issue in mosh wrapper, related to mosh to hostname.

* mosh-client.exe updated with 32 bit version for x86 platform (#59)

* Set line endings for remote shell connection;
Left focus on SSH info dialog if input validation error occured;
Update DataContext object on each key entered into target host text box control.

* Simplifying SSH dialog.

* Fixing some leftovers after merging.

* Fixing some after-merge issues.

* Avoiding some unintentional upstream changes.

* Fix review findings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fixed in next release This is already fixed and will be included in the next release help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants