This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
Book Info from ISBN #368
Merged
Book Info from ISBN #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chirag-ghosh
commented
Apr 24, 2022
chirag-ghosh
commented
hargup
suggested changes
Apr 28, 2022
There was a problem hiding this comment.
Similar to the other PR, can you link the card to the Google books page of the book?
I'll also like the styling to be consistent. You can use the used in this figma file.
https://www.figma.com/file/8frpfzhydbtVuiLr5GWzcZ/15-Mar---UI-redesign?node-id=0%3A1
The important changes are around the background color and border, don't need to bother with other things.
|
Sure. |
hargup
approved these changes
May 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.