Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added my fable #4

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

added my fable #4

wants to merge 8 commits into from

Conversation

kurtsy
Copy link

@kurtsy kurtsy commented Aug 12, 2014

css and index should be here

@femmebot
Copy link
Owner

Thanks so much! A few things I noticed at quick glance:
— CSS clean-up: Noticed there were several H# tags used. Should consolidate into just H2 since it's just one heading. Same for p tags. Consolidate all sentences into a single paragraph. Also noticed unused classes.
— Import only the Google font weights/styles in use instead of the entire font family.
— Responsive design: How did you want to handle tablet and mobile views?
— Body text: The typeface News Cycle doesn't connect with the heading. I suggest something like Trocchi or something that matches the geometry of Libre Baskerville at least. Here's a short guide from HF&J on combining typefaces: http://www.typography.com/techniques/
Happy to dive into this over the weekend when I have more time if you don't get a chance to address during the week.

@@ -18,6 +18,7 @@ h1, h2, p { margin: 0; padding: 0; }
.section-intro a { color: #000; text-decoration: none; }
.section-intro a:hover { background-color: #ddd; }

<<<<<<< HEAD

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase derp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants