Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lh3/minimap2 please adopt your --secondary-seq patch #275

Closed
smoe opened this issue Jun 6, 2020 · 6 comments
Closed

lh3/minimap2 please adopt your --secondary-seq patch #275

smoe opened this issue Jun 6, 2020 · 6 comments

Comments

@smoe
Copy link

smoe commented Jun 6, 2020

Hello,

Debian Med wants to help where it can, hoping that bringing the Nanopore and associated software closer to a regular Linux distribution may attract additional eyeballs and help spread the technology.

These Linux distributions are a bit peculiar in their ambition to package every software only once and so it happened that the straight-forward attempt to reuse the distribution's package of minimap2 overlooked your --secondary-seq contribution to it.

I went through https://github.com/lh3/minimap2/pulls but did not find a respective pull request. Are you in contact with @lh3 about it? I had a look at the patch and did not find anything overly risky about adopting it for our distribution - but that would be confusing

To help finding (and recording for everyone's inspection), instead of shipping minimap2 within the lib directory you may consider forking https://github.com/lh3/minimap2 and have it as git submodule. Then, please create a pull request :o) If you are too busy but would appreciate that happening then I can do that for you.

Many thanks and regards

Steffen

@fenderglass
Copy link
Owner

Hi Steffen,

Yes, I am planning to submit a pull request in the near future. Will keep you posted.

Thanks,
Mikhail

@fenderglass
Copy link
Owner

Opened a pull request: lh3/minimap2#687

@tillea
Copy link

tillea commented May 5, 2022

I realised your pull request is marked "This branch has conflicts that must be resolved" Would you mind to revise your patch? I'd love to package flye for Debian but it seems this issue has stalled.

@fenderglass
Copy link
Owner

@tillea I'm waiting for a confirmation from minimap2 developers that they are interested in adopting the patch. Then I'll be happy to update the pull request. Thanks for checking.

@fenderglass
Copy link
Owner

Looks like lh3/minimap2#687 is now merged

@lh3
Copy link

lh3 commented Apr 21, 2023

Thank you, @fenderglass for the PR. I am likely to cut a minimap2 release next week after some pre-release testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants