Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build failure with gcc 13 #621

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Conversation

emollier
Copy link
Contributor

As seen initially in Debian bug#1037662, per gcc 13 porting guide, there have been header dependency changes resulting in the following build errors:

In file included from repeat_graph/repeat_graph.h:10,
                 from repeat_graph/graph_processing.h:10,
                 from repeat_graph/graph_processing.cpp:7:
repeat_graph/../sequence/sequence_container.h:21:37: error: expected ‘)’ before ‘id’
   21 |                 explicit Id(uint32_t id): _id(id) {}
      |                            ~        ^~~
      |                                     )
repeat_graph/../sequence/sequence_container.h:69:17: error: ‘uint32_t’ does not name a type
   69 |                 uint32_t _id;
      |                 ^~~~~~~~
repeat_graph/../sequence/sequence_container.h:13:1: note: ‘uint32_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?

[…]

In file included from polishing/alignment.h:14,
                 from polishing/alignment.cpp:5:
polishing/subs_matrix.h:47:34: error: ‘uint32_t’ has not been declared
   47 |                 State(char nucl, uint32_t length);
      |                                  ^~~~~~~~
polishing/subs_matrix.h:53:17: error: ‘uint32_t’ does not name a type
   53 |                 uint32_t length;
      |                 ^~~~~~~~
polishing/subs_matrix.h:13:1: note: ‘uint32_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?

Including cstdint in the affect header files fixes the issue.

As seen initially in [Debian bug#1037662], per [gcc 13 porting guide],
there have been header dependency changes resulting in the following
build errors:

	In file included from repeat_graph/repeat_graph.h:10,
	                 from repeat_graph/graph_processing.h:10,
	                 from repeat_graph/graph_processing.cpp:7:
	repeat_graph/../sequence/sequence_container.h:21:37: error: expected ‘)’ before ‘id’
	   21 |                 explicit Id(uint32_t id): _id(id) {}
	      |                            ~        ^~~
	      |                                     )
	repeat_graph/../sequence/sequence_container.h:69:17: error: ‘uint32_t’ does not name a type
	   69 |                 uint32_t _id;
	      |                 ^~~~~~~~
	repeat_graph/../sequence/sequence_container.h:13:1: note: ‘uint32_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?

[…]

	In file included from polishing/alignment.h:14,
	                 from polishing/alignment.cpp:5:
	polishing/subs_matrix.h:47:34: error: ‘uint32_t’ has not been declared
	   47 |                 State(char nucl, uint32_t length);
	      |                                  ^~~~~~~~
	polishing/subs_matrix.h:53:17: error: ‘uint32_t’ does not name a type
	   53 |                 uint32_t length;
	      |                 ^~~~~~~~
	polishing/subs_matrix.h:13:1: note: ‘uint32_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?

Including cstdint in the affect header files fixes the issue.

[Debian bug#1037662]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1037662
[gcc 13 porting guide]: https://gcc.gnu.org/gcc-13/porting_to.html

Signed-off-by: Étienne Mollier <emollier@debian.org>
@fenderglass fenderglass merged commit 40b9ea0 into fenderglass:flye Aug 18, 2023
@fenderglass
Copy link
Owner

Thank you, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants