Allow User Stream to use track parameters #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. (I notice the /site mode does not have the track parameter (https://dev.twitter.com/docs/api/1.1/get/site) so the code, limiting it to you have is correct.) BTW, do you have any interest in making it more generic; someone recently asked for access to the "with" parameter, and I notice there are some other new-ish parameters in the API. |
DarrenCook
added a commit
that referenced
this pull request
Mar 6, 2014
Allow User Stream to use track parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless I've missed something, the Phirehose library currently won't accept any track parameters even though it looks like they should be allowed according to: https://dev.twitter.com/docs/api/1.1/get/user
This PR adds the ability to add track parameters using the usual setTrack function.