fix: fix error being catchable with bad video id

closes #121 (again)
fent · Jan 2, 2021 · 6560c66 · 6560c66
1 parent 3dcf7fb
commit 6560c66
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 6 deletions.
diff --git a/lib/info.js b/lib/info.js
@@ -470,9 +470,9 @@ for (let funcName of ['getBasicInfo', 'getInfo']) {
    * @returns {Promise<Object>}
    */
   const func = exports[funcName];
-  exports[funcName] = (link, options = {}) => {
+  exports[funcName] = async(link, options = {}) => {
     utils.checkForUpdates();
-    let id = urlUtils.getVideoID(link);
+    let id = await urlUtils.getVideoID(link);
     const key = [funcName, id, options.lang].join('-');
     return exports.cache.getOrSet(key, () => func(id, options));
   };

diff --git a/test/basic-info-test.js b/test/basic-info-test.js
@@ -452,11 +452,22 @@ describe('ytdl.getBasicInfo()', () => {
     });
 
     describe('With a bad video ID', () => {
-      it('Returns an error', () => {
+      it('Throws a catchable error', async() => {
         const id = 'bad';
-        assert.throws(() => {
-          ytdl.getBasicInfo(id);
-        }, /No video id found: bad/);
+        try {
+          await ytdl.getBasicInfo(id);
+        } catch (err) {
+          assert.ok(/No video id found/.test(err.message));
+          return;
+        }
+        throw Error('should not get here');
+      });
+      it('Promise is rejected with caught error', done => {
+        const id = 'https://website.com';
+        ytdl.getBasicInfo(id).catch(err => {
+          assert.ok(/Not a YouTube domain/.test(err.message));
+          done();
+        });
       });
     });