call to getInfo() might result in surprising exception being thrown

[azrafe7]

Not sure if this should be fixed somehow, but thought I'd report it anyway (as a heads-up)... 😛

Using getInfo() would force you to wrap the call in a try/catch block, as the inner call to getVideoID() might throw an Error if no id is found.

Now - especially when using the promisified version - this behaviour might be surpising from a user point of view, which probably expects to grab the error in a .catch() statement.

[fent]

It was originally made that way because I compared it to how other native js functions handle bad parameters. But it does make sense, since this is an async function, to pass the error to the callback or the promise. Rather than having the user check two places.

[cocoliliace]

I'm facing this issue on v4.3.0 when the input is not a youtube link. When I call

ytdl.getInfo("https://github.com").catch(error => console.log(error));

The catch block doesn't seem to catch anything and I get an error from the parent function instead

[github-actions]

🎉 This issue has been resolved in version 4.3.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀