Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not get response #586

Closed
krisnguyen95 opened this issue Mar 4, 2020 · 6 comments · Fixed by fent/node-miniget#44
Closed

Could not get response #586

krisnguyen95 opened this issue Mar 4, 2020 · 6 comments · Fixed by fent/node-miniget#44
Labels

Comments

@krisnguyen95
Copy link

krisnguyen95 commented Mar 4, 2020

My server has been running the ytdl-core library for some time but now getInfo doesn't return a response anymore. I have a log in the library but only the request, not any response. Help me please
Screen Shot 2020-03-04 at 10 27 01 PM

@TimeForANinja
Copy link
Collaborator

looks like you're not on latest version 🤔

@fent fent added the support label Apr 7, 2020
@rpradeepam
Copy link

I am seeing a similar behavior. Getting responses properly, but not getting errors where I'm expecting to get 429, 403, etc.
Could it be because of this?
image
When using a callback, if the getBasicInfo function thrown an error, it is not passed to the callback

@fent
Copy link
Owner

fent commented May 6, 2020

does it say something like unhandled promise error thrown or uncaught error?

@rpradeepam
Copy link

I hadn't been able to capture logs consistently. I have moved to using promises now anyway.

I had my code setup to check for 429 errors and handle them by getting a new IP, which was working fine.
Over the past few months I had noticed that occasionally the getInfo method would stop returning data. My requests would just time out.
Getting a new IP seemed to fix the problem, leading me to believe that I was getting 429s but not able to capture them.

@WaqasIbrahim
Copy link
Contributor

WaqasIbrahim commented May 7, 2020

@fent, I believe this is an issue with miniget retrying requests for 429 status code.
Fix: fent/node-miniget#44

@jensbrehmen
Copy link

I'm encountering the same problem. I'm not getting any response from getInfo, it just keeps on loading. What's strange is that there are no errors whatsoever in my server logs.

fent pushed a commit to fent/node-miniget that referenced this issue May 25, 2020
Fixes: fent/node-ytdl-core#586
Fixes #31

* fix no error thrown on status 429

* add test for multiple tries on status 429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants