Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix no error thrown on status 429 #44

Merged
merged 2 commits into from
May 25, 2020
Merged

fix no error thrown on status 429 #44

merged 2 commits into from
May 25, 2020

Conversation

WaqasIbrahim
Copy link
Contributor

@WaqasIbrahim WaqasIbrahim commented May 7, 2020 •
edited by fent
Loading

@WaqasIbrahim WaqasIbrahim mentioned this pull request May 7, 2020
Closed
fent
fent requested changes May 23, 2020
View reviewed changes
Copy link
Owner

@fent fent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! thanks for this, sorry I didn't reply earlier, I missed it somehow.

do you mind adding a test to tests/request-test.ts to cover the case where this happens?

@WaqasIbrahim
Copy link
Contributor Author

Test added.

@fent fent merged commit bf05b26 into fent:master May 25, 2020
@fent
Copy link
Owner

fent commented May 25, 2020

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fent fent fent requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Could not get response Retry logic doesn't handle maxRetries threshold properly
2 participants
@WaqasIbrahim @fent