Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock snapcraft to v5 since v7 breaks the build #259

Merged
merged 1 commit into from Jun 15, 2022
Merged

Lock snapcraft to v5 since v7 breaks the build #259

merged 1 commit into from Jun 15, 2022

Conversation

vraravam
Copy link
Contributor

@vraravam vraravam commented Jun 15, 2022 •
edited

versions available at: https://snapcraft.io/snapcraft

Pre-flight Checklist

  1. Please remember that if you are logging a bug for some service that has stopped working or is working incorrectly, please log the bug here
  2. If you are requesting support for a new service in Ferdium, please log it here
  3. Please remember to read the self-help documentation - in case it helps you unblock yourself for issues related to older versions of recipes that were installed on your machine. (These will get automatically upgraded when you upgrade to the newer versions of Ferdium, but to get new recipes between Ferdium releases, this documentation is quite useful.)
  4. Please ensure you've completed all of the following.

Description of Change

Trying to fix the build by locking on v5.x (prior to v7, the latest version available is v5: https://snapcraft.io/snapcraft)

Motivation and Context

Get successful nightly builds.

Screenshots

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (npm run prepare-code)
  • npm test passes
  • I tested/previewed my changes locally

Release Notes

@vraravam vraravam requested a review from a team June 15, 2022 09:20
@vraravam vraravam self-assigned this Jun 15, 2022
SpecialAro
SpecialAro approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@SpecialAro SpecialAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should fix. Though, we should try to fix it for v7.x when we have the time

.github/workflows/builds.yml
@@ -261,7 +261,7 @@ jobs:
CSC_IDENTITY_AUTO_DISCOVERY: false
SNAPCRAFT_LOGIN: ${{ secrets.SNAPCRAFT_LOGIN }}
run: |
sudo snap install snapcraft --classic
sudo snap install snapcraft --channel=5.x/stable --classic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be v6.1 as per this successful build https://github.com/ferdium/ferdium-app/runs/6872922102?check_suite_focus=true#step:16:20

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V6 isnt listed at https://snapcraft.io/snapcraft
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V6 isnt listed at https://snapcraft.io/snapcraft image

Weird :o

@NathanaelGandhi , by any chance do you have time to adapt our build to 7.x today?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - this page doesn't list any 6.x - thus, I left it at 5.x

.github/workflows/builds.yml
@@ -273,7 +273,7 @@ jobs:
CSC_IDENTITY_AUTO_DISCOVERY: false
SNAPCRAFT_LOGIN: ${{ secrets.SNAPCRAFT_LOGIN }}
run: |
sudo snap install snapcraft --classic
sudo snap install snapcraft --channel=5.x/stable --classic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be v6.1 as per this successful build https://github.com/ferdium/ferdium-app/runs/6872922102?check_suite_focus=true#step:16:20

.github/workflows/builds.yml
@@ -285,7 +285,7 @@ jobs:
CSC_IDENTITY_AUTO_DISCOVERY: false
SNAPCRAFT_LOGIN: ${{ secrets.SNAPCRAFT_LOGIN }}
run: |
sudo snap install snapcraft --classic
sudo snap install snapcraft --channel=5.x/stable --classic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be v6.1 as per this successful build https://github.com/ferdium/ferdium-app/runs/6872922102?check_suite_focus=true#step:16:20

@vraravam vraravam merged commit 6a3c3d0 into ferdium:develop Jun 15, 2022
@vraravam vraravam deleted the lock-snapcraft branch June 15, 2022 13:38
@vraravam vraravam mentioned this pull request Jun 15, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanaelGandhi NathanaelGandhi NathanaelGandhi left review comments

@SpecialAro SpecialAro SpecialAro approved these changes

Assignees

@vraravam vraravam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vraravam @NathanaelGandhi @SpecialAro