Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to fix snap login issues #272

Merged
merged 1 commit into from Jun 15, 2022
Merged

Conversation

vraravam
Copy link
Contributor

@vraravam vraravam commented Jun 15, 2022

Pre-flight Checklist

  1. Please remember that if you are logging a bug for some service that has stopped working or is working incorrectly, please log the bug here
  2. If you are requesting support for a new service in Ferdium, please log it here
  3. Please remember to read the self-help documentation - in case it helps you unblock yourself for issues related to older versions of recipes that were installed on your machine. (These will get automatically upgraded when you upgrade to the newer versions of Ferdium, but to get new recipes between Ferdium releases, this documentation is quite useful.)
  4. Please ensure you've completed all of the following.

Description of Change

Changes based on https://github.com/ferdium/ferdium-app/runs/6909416552?check_suite_focus=true#step:16:21

Motivation and Context

#259 didn't work

Screenshots

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (npm run prepare-code)
  • npm test passes
  • I tested/previewed my changes locally

Release Notes

@vraravam vraravam requested a review from a team June 15, 2022 23:17
@vraravam vraravam self-assigned this Jun 15, 2022
@vraravam
Copy link
Contributor Author

Have to merge and trigger a nightly build to test this out unfortunately.

@vraravam vraravam merged commit 20fda39 into ferdium:develop Jun 15, 2022
@vraravam vraravam deleted the snapcraft-v7 branch June 15, 2022 23:19
@SpecialAro
Copy link
Member

@SpecialAro
Copy link
Member

Also, this https://github.com/ferdium/ferdium-app/runs/6909688043?check_suite_focus=true#step:16:83 may be a problem in the future as well.

@vraravam
Copy link
Contributor Author

vraravam commented Jun 16, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants