Fix typo in exportparts syntax example #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[According to the spec](https://drafts.csswg.org/css-shadow-parts/#parsing-mapping), when forwarding parts, the idents in the part mapping should be separated by a colon (`:`) not a space. Perhaps this was an accidental omission (I have not tested the code). The example in the spec [Example 2](https://drafts.csswg.org/css-shadow-parts/#example-d23fb781) is seemingly at odds with the explanation of the algorithm for parsing the parts mapping, also missing the comma.
|
Space was used as the separator in an early draft, I guess I just missed that one when updating. Thanks! |
oslego
added a commit
to oslego/csswg-drafts
that referenced
this pull request
Dec 11, 2018
As noted in the [fix for the explainer doc](fergald/docs#2), this missing colon is probably an oversight after the syntax change.
|
Thank you for merging! I tried to update the example in the spec too, but it seems I can't because my account fails an affiliation check. It is a non-substantive change (fixing a typo). You may decide what's easier: either accept that PR as-is or fix the typo in another commit at your convenience. |
|
Looks like @tabatkins got it already. Thanks.
…On Wed, 12 Dec 2018 at 03:17, Razvan Caliman ***@***.***> wrote:
Thank you for merging!
I tried to update <w3c/csswg-drafts#3429> the
example in the spec too, but it seems I can't because my account fails an
affiliation check. It is a non-substantive change (fixing a typo).
You may decide what's easier: either accept that PR as-is or fix the typo
in another commit at your convenience.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#2 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEDu51nkaHD_qxxZ1sKL1eERrcglfAW_ks5u3_algaJpZM4ZL34p>
.
|
|
Yeah, it was a non-substantial edit, so the affiliation check doesn't matter and I just bypassed it. |
|
Thank you, both!
…On Fri, Dec 14, 2018 at 11:49 PM Tab Atkins Jr. ***@***.***> wrote:
Yeah, it was a non-substantial edit, so the affiliation check doesn't
matter and I just bypassed it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD5m0um9vfYn0E_70trxpWbprk7NlaOks5u5BzsgaJpZM4ZL34p>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the spec, when forwarding parts, the idents in the part mapping should be separated by a colon (
:) not a space. Perhaps this was an accidental omission (I have not tested the code).The example in the spec Example 2 is seemingly at odds with the explanation of the algorithm for parsing the parts mapping, also missing the colon.