Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to update search-index version to newest #156

Closed
wants to merge 2 commits into from
Closed

Trying to update search-index version to newest #156

wants to merge 2 commits into from

Conversation

eklem
Copy link
Collaborator

@eklem eklem commented Feb 24, 2018

Updating to newest version of search-index and adding tests for all versions of Node.js still supported.

This one will fail, but good to have a pull request to have a discussion.

Here's the test that fails:

# should get latest snapshot and import in into a new norch
not ok 284 Error: socket hang up
  ---
    operator: error
    expected: |-
      undefined
    actual: |-
      { [Error: socket hang up] code: 'ECONNRESET' }
    at: Request.<anonymous> (/Users/eklem/github_modules/norch/test/test.js:160:9)
    stack: |-
      Error: socket hang up
          at createHangUpError (_http_client.js:331:15)
          at Socket.socketOnEnd (_http_client.js:423:23)
          at emitNone (events.js:111:20)
          at Socket.emit (events.js:208:7)
          at endReadableNT (_stream_readable.js:1055:12)
          at _combinedTickCallback (internal/process/next_tick.js:138:11)
          at process._tickDomainCallback (internal/process/next_tick.js:218:9)
  ...

This error was introduced with version 0.12.0 of search-index where the add interface became streamy.

@eklem
Copy link
Collaborator Author

eklem commented Feb 24, 2018

So the /snapshot endpoint seems to not work as intended anymore?

@fergiemcdowall
Copy link
Owner

fergiemcdowall commented Feb 24, 2018 via email

@eklem
Copy link
Collaborator Author

eklem commented Feb 26, 2018

It's a bit to much unknown teritory for me to figure out on my own, but let me know if you want me to test different things.

@fergiemcdowall
Copy link
Owner

Will do

@eklem
Copy link
Collaborator Author

eklem commented Feb 26, 2018

Actually, it seems it's the /latestSnapshot that is not working (if the /snapshot test is good enough).

@fergiemcdowall
Copy link
Owner

Ahh- in that case TODO: make a test for /latestSnapshot

@eklem eklem closed this Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants