Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iojs for tests at travis. #149

Closed
wants to merge 20 commits into from
Closed

Add iojs for tests at travis. #149

wants to merge 20 commits into from

Conversation

mewwts
Copy link
Collaborator

@mewwts mewwts commented Aug 15, 2015

No description provided.

@mewwts mewwts self-assigned this Aug 15, 2015
@fergiemcdowall
Copy link
Owner

Bad things happening- not sure why...

F

On Sat, Aug 15, 2015 at 7:39 PM, Mats Julian Olsen <notifications@github.com

wrote:

Lul, I absolutely can't see the failing test case in the logs!


Reply to this email directly or view it on GitHub
#149 (comment)
.

@mewwts
Copy link
Collaborator Author

mewwts commented Aug 15, 2015

Yup. Looks like the npm install fails on the iojs side. Probably something silly.

@mewwts
Copy link
Collaborator Author

mewwts commented Aug 15, 2015

Ah, OK.
See nodejs/node#433

@mewwts
Copy link
Collaborator Author

mewwts commented Aug 15, 2015

Btw @fergiemcdowall looks like the configuration test fails off and on. Fixes itself when I rerun it. Any clues?

@mewwts
Copy link
Collaborator Author

mewwts commented Aug 15, 2015

Will just leave this here unmerged while I research this.

@mewwts
Copy link
Collaborator Author

mewwts commented Aug 24, 2015

I rebased onto master.

@mewwts
Copy link
Collaborator Author

mewwts commented Aug 24, 2015

This faiils on the node.js side:

1) Matching epub:  should match on all fields and return IDs:

      AssertionError: expected false to be true

      + expected - actual

      -false

      +true



      at test/general-tests/matching-test.js:79:32

      at Object.matcher.matcher (lib/matchers/matcher.js:12:14)

      at Object.SearchIndex.match (lib/search-index.js:194:13)

      at Context.<anonymous> (test/general-tests/matching-test.js:77:8)


It fails on my computer too, @fergiemcdowall?

@mewwts mewwts closed this Aug 24, 2015
@mewwts mewwts deleted the iojs branch August 24, 2015 07:48
@mewwts
Copy link
Collaborator Author

mewwts commented Aug 24, 2015

Trying this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants