add cloud logs command

[rajatjindal]

spin-cloud-logs 0.1.2 (b977558 2023-08-11)
Logs fetches app logs from Fermyon Cloud

USAGE:
    spin cloud logs [OPTIONS] --app-name <app-name>

OPTIONS:
        --app-name <app-name>
            App name

        --environment-name <environment-name>
            Find app to fetch logs for in the Fermyon instance saved under the specified name. If
            omitted, Spin looks for app in default unnamed instance [env:
            FERMYON_DEPLOYMENT_ENVIRONMENT=]

        --follow
            Follow logs output

    -h, --help
            Print help information

        --interval <interval>
            interval in secs to refresh logs from cloud [default: 5]

        --tail <tail>
            Number of lines to show from the end of the logs [default: 10]

    -V, --version
            Print version information

[rylev]

I'd like to figure out if there's a way to do this without repeatedly downloading all logs.

[kate-goldenring]

Thanks for adding this Rajat! To @rylev's point, instead of getting all logs, can you update channel_logs to take in max aka count. The api_channels_id_logs_get already has support for requesting n many logs and it is the latest n returned by journal.

[rajatjindal]

Thanks for adding this Rajat! To @rylev's point, instead of getting all logs, can you update channel_logs to take in max aka count. The api_channels_id_logs_get already has support for requesting n many logs and it is the latest n returned by journal.

I want to do that too. but lets say we start the tail command and fetched 100 lines of logs. now the app added 5 new line of logs. when we ask for 100 lines of logs again, how do we know that the last 5 are the latest ones to display?

[rajatjindal]

Thanks for adding this Rajat! To @rylev's point, instead of getting all logs, can you update channel_logs to take in max aka count. The api_channels_id_logs_get already has support for requesting n many logs and it is the latest n returned by journal.

I want to do that too. but lets say we start the tail command and fetched 100 lines of logs. now the app added 5 new line of logs. when we ask for 100 lines of logs again, how do we know that the last 5 are the latest ones to display?

I looked at the logging api code. if we can add ability to say "give me logs since ", then we might be able to circumvent the problem. I'll give that a try soon.

cc @michelleN - I know you were looking at the logging api as well.

[rajatjindal]

this will fix #107

[kate-goldenring]

Thanks for updating the APIs to make this possible @rajatjindal

[rajatjindal]

+1 using some color for the prefix could be nice here as well.

chatted with Ryan, and adding a color to prefix can be done as a follow up PR. thanks

[rajatjindal]

@kate-goldenring @rylev @itowlson @karthik2804

thank you for your feedback on this PR. I think this is now ready to be merged. please let me know if there are comments that I might have missed to address.

thanks

[itowlson]

I don't think anything I have is blocking (though it would be highly desirable to get rid of that panic), but I don't feel I know enough to approve, sorry.

[rajatjindal]

@itowlson, as always, thank you for your insightful feedback on this PR.

[itowlson]

Looking good @rajatjindal, just one question and one thing that I mentioned in a comment but forgot to log in the review - sorry about that!

[bacongobbler]

Would you mind changing this to use the /api/apps/:id/logs endpoints? The latest version of the cloud-openapi client contains these endpoints. The channel log endpoints are planned to be deprecated soon.

fermyon/cloud-openapi#10

[rajatjindal]

I have updated openapi client and updated the PR to use new endpoints.

[radu-matei]

Tested this end to end and everything looks great!

LGTM

[rylev]

Just some last second code nits. Feel free to merge this without addressing those!

[kate-goldenring]

LGTM! Thanks @rajatjindal