Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update SDK, use wasi-http streaming, etc. #43

Merged
merged 6 commits into from
Nov 2, 2023

Conversation

dicej
Copy link
Contributor

@dicej dicej commented Oct 30, 2023

The main change is to support streaming so we don't need to buffer each file entirely into memory. This required a bit of refactoring. This also adds deflate and gzip encoding support since it was easy.

I've also added an examples directory to illustrate how to compose the server with applications. Currently, there's just one Rust example, but I'm planning to add more for other languages.

We should probably delay merging this until Spin 2.0 is released, since it requires stable component support.

The main change is to support streaming so we don't need to buffer each file
entirely into memory.  This required a bit of refactoring.

This also adds `deflate` and `gzip` encoding support since it was easy.

Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, manually tested this with a few static-asset-heavy applications and everything LGTM.

Also tested the composition example, which is a great addition!

Thanks!

Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
@radu-matei radu-matei merged commit 998c464 into fermyon:main Nov 2, 2023
2 checks passed
@dicej dicej deleted the composition branch November 2, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants