Pin the version of spin componentize we're using #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
fibonacci1729
approved these changes
Apr 29, 2023
Mossaka
reviewed
May 1, 2023
Cargo.toml
Outdated
| wasi-host = { package = "host", git = "https://github.com/fermyon/spin-componentize" } | ||
| wasi-common = { git = "https://github.com/fermyon/spin-componentize" } | ||
| wasi-cap-std-sync = { git = "https://github.com/fermyon/spin-componentize" } | ||
| spin-componentize = { git = "https://github.com/fermyon/spin-componentize", rev = "9e7ec95ccaf490c9b96c03af1c818e8197ccf855" } |
There was a problem hiding this comment.
lgtm!
nit: create a git tag to spin-componentize repo and then pin to this specific tag could make Cargo.toml much more readable.
There was a problem hiding this comment.
I agree though we're iterating a bit currently. Once it settles, I think we can tag a release that's meant for the next version of spin.
Mossaka
approved these changes
May 1, 2023
dicej
approved these changes
May 1, 2023
This required updating to the latest `wit-bindgen`, `spin-componentize`, and `wasmtime` to avoid dependency conflicts. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
|
I had to update the |
|
This should be good to merge. This brings in the changes from #1433 so we can close that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1437