Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to wasmtime 8.0.1 #1433

Closed
wants to merge 1 commit into from
Closed

Upgrade to wasmtime 8.0.1 #1433

wants to merge 1 commit into from

Conversation

rylev
Copy link
Collaborator

@rylev rylev commented Apr 28, 2023

This brings spin much further forward with regards to its usage of upstream wasm libraries which enables a lot more experimentation with new standards around the component model. For users this should effectively be a noop.

Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
@rylev rylev requested a review from dicej April 28, 2023 16:16
@Mossaka
Copy link
Contributor

Mossaka commented Apr 28, 2023

This PR might resolve issue #1437

@rylev
Copy link
Collaborator Author

rylev commented Apr 29, 2023

The failing test is due to the fact that we're defining our spin world in two different ways (due to the fact that our SDKs use old versions of wit-bindgen - fixed in #1424 - while our host implementation uses newer style wit documents). The config interface is called "spin-config" in the SDK while the host expects just "config". spin-componentize is smoothing this out for older modules which is why this wasn't an issue before, but we updated the failing test to use wit-bindgen 0.6 which thus skips over the spin-componentize world massaging.

For now, we can merge fermyon/spin-componentize#7 and revert the broken test to use wit-bindgen 0.4, but we'll eventually want to fix the issue of our world definitions not aligning. When #1424 is merged we can move to using the same wit definitions for both guest and host.

@rylev
Copy link
Collaborator Author

rylev commented May 2, 2023

Superseded by #1439.

@rylev rylev closed this May 2, 2023
@rylev rylev deleted the wasmtime-8 branch May 2, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants