Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misleading error message if built-in app trigger was missing required parameter #1440

Merged
merged 1 commit into from May 1, 2023
Merged

Fix misleading error message if built-in app trigger was missing required parameter #1440

merged 1 commit into from May 1, 2023

Conversation

itowlson
Copy link
Contributor

Fixes #1434.

$ spin up -f ./crates/loader/tests/missing-http-base.toml 
Error: Cannot read spin.toml manifest from "/home/ivan/github/spin/crates/loader/tests/missing-http-base.toml"

Caused by:
    could not load application trigger parameters: missing field `base` at line 11 column 1

@itowlson
Fix misleading error message if built-in app trigger was missing requ…
439d371 
…ired parameter

Signed-off-by: itowlson <ivan.towlson@fermyon.com>
@fibonacci1729
Copy link
Contributor

Looks good, worked for me!

@itowlson itowlson merged commit 5bcc14b into fermyon:main May 1, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fibonacci1729 fibonacci1729 fibonacci1729 approved these changes

@lann lann Awaiting requested review from lann

@rylev rylev Awaiting requested review from rylev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"No built-in trigger named 'http'" if trigger.base is missing
2 participants
@itowlson @fibonacci1729