Change handler entrypoint name convention
#208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I approve but I also hassled you into these names so I will abstain. |
radu-matei
reviewed
Mar 22, 2022
radu-matei
reviewed
Mar 22, 2022
| @@ -26,10 +26,10 @@ defined using | |||
|
|
|||
| ```fsharp | |||
| // The entrypoint for an HTTP handler. | |||
| handler: function(req: request) -> response | |||
| handle-http-request: function(req: request) -> response | |||
There was a problem hiding this comment.
❤️
Thanks for updating the docs!
|
Not related to this PR, but we should also update all tests to use the SDKs instead of relying on interface files everywhere. |
radu-matei
approved these changes
Mar 22, 2022
ref #196 Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #196
Signed-off-by: Brian Hardock brian.hardock@fermyon.com