Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new manageResources flag will prevent plugin from creating or configu… #75

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

sprockow
Copy link
Contributor

new manageResources flag will prevent plugin from creating or configuring s3 bucket

Background

#3 - This adds a flag that allows a user to opt out of having serverless-finch create or configure the s3 bucket, and instead rely on an existing bucket, or a cloudformation definition.

Proposed changes

adds a new manageResources flag

Proposed reviewers (optional)

[@ mentions of other contributors]

@fernando-mc
Copy link
Owner

@sprockow I'll get this into the next version. It might take a little bit because I'm also trying to push a fix to issues I haven't been able to reproduce yet.

The feature looks great. 👍

@fernando-mc fernando-mc merged commit 54385eb into fernando-mc:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants