Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redmine 1.3.x support #66

Closed
ghost opened this issue Jan 16, 2012 · 7 comments
Closed

redmine 1.3.x support #66

ghost opened this issue Jan 16, 2012 · 7 comments
Labels

Comments

@ghost
Copy link

ghost commented Jan 16, 2012

Hi,

Are there any plans to support redmine 1.3.x?

When I try to use it, I get this error:

ActionController::RoutingError in Welcome#index

Showing vendor/plugins/redmine_time_tracker/app/views/time_trackers/_embed_menu.rhtml where line #52 raised:

No route matches {:controller=>"time_trackers", :action=>"index"}

Extracted source (around line #52):

49: 
50: <% if User.current.allowed_to?(:log_time, nil, :global => true) or User.current.allowed_to?(:view_others_time_trackers, nil, :global => true) %>
51:     <span>
52:         <%= link_to '',
53:             { :controller => 'time_trackers', :action => 'index' },
54:             { :class => 'icon-action icon-list-action', :title => l(:list_time_trackers) }
55:         %>

Trace of template inclusion: vendor/plugins/redmine_time_tracker/app/views/time_trackers/_update_menu.rhtml, app/views/layouts/base.html.erb

Thanx,

Ionutz

@delaitre
Copy link
Collaborator

According to #64, the plugin is working on redmine 1.3.0. I've not tested myself though.

I've noticed on the redmine forum that some people have problem with the plugin and redmine 1.3. I have no free time to work on it however.

Moreover, we've switch from redmine to chiliproject in my company. So if I found time to rework on the plugin, this will be tested on chiliproject, not redmine (I'll will probably need to rename the plugin...). If anyone wants to take maintership of the plugin, I'll be very happy to support him as the project is not actively develop anymore...

@ghost
Copy link
Author

ghost commented Jan 21, 2012

The error was on trunk (future 1.4), not 1.3.0.

@borco borco closed this as completed Jan 21, 2012
@delaitre delaitre reopened this Jan 22, 2012
@delaitre
Copy link
Collaborator

Ok, I reopen the issue then...

@kotashiratsuka
Copy link

I needed route change as follows.

Index: config/routes.rb
===================================================================
--- config/routes.rb    (revision 8866)
+++ config/routes.rb    (working copy)
@@ -409,6 +409,7 @@
 
   map.connect 'robots.txt', :controller => 'welcome',
               :action => 'robots', :conditions => {:method => :get}
+  map.connect ':controller/:action/:id'
 
   # Used for OpenID
   map.root :controller => 'account', :action => 'login'

@delaitre
Copy link
Collaborator

I'm not a web/rails guru and I don't really know what a route is. Could you explain what your change does and why it's needed now while it was working before? Is adding a route safe or can it lead to security issue? Is there other way to fix the problem?

Thanks in advance!

@cforce
Copy link
Contributor

cforce commented Jun 19, 2012

The route maps urls to controller methods in rails, comparable to servlets in java.

Is this routes.rb (in fact redmine 1.4 support now part of your master)

Seems like, according to #72

So this issue is closed and redmine 1.4 is supported?

@delaitre
Copy link
Collaborator

Yes it works (the development version) with Redmine 1.4. Thank you for pointing me this already fixed bug!

fernandokosh pushed a commit that referenced this issue Apr 11, 2014
*renamed standard validate func
*added validate func for timetracker form
*fixed list entry containing activity id validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants