-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Save] doesn't 'dim' after a Save, plus ... #68
Comments
Thanks a lot for the feedback! See below my comments:
|
Everything is implemented except 1&2. I am still undecided in terms of how to show the user that the save operation was successful (a message box seems too disruptive). However, just looking at how Excel does this: first the mouse shows the loading icon, then the saving occurs, then back to normal. No message, no UI feedback, and the save button is still enabled (even though Excel opens files with exclusive access and hence no external changes should occur). I think I will go for a similar approach, the only difference respect from now being the loading mouse icon. |
Really like it - much easier to use that the original version. Some minor feedback to consider
Before opening a file [Save] is dim. After opening, but before making any changes, [Save] is enabled. It seems to me that [Save] should be disabled until the user makes a change (i.e. file is Dirty)
After saving, the [Save] button is still enabled. Seems to me that it should be disabled (dimmed) since the file is no longer dirty
When opening a file, the customUI.xml 'browser' on the left is selected, but no XML is displayed until the user double-clicks. Seems to me that since customUI.xml is selected on opening, the associated XML should be also automatically displayed
[Reload on Save] on the menu bar seems to have an inactive (never active) 'menu selection dropdown' on the right side. Maybe a ToggleButton control would be better (?)
Settings dialog [Apply] is always enabled. Seems like that button (and possibly [Accept]) should be dim until the user makes a change, and then go back to dimmed after changes are committed
Still haven't figured out the rules behind when [Insert Icons is enabled. Opening file with customUI.xml selected (not displayed Finish creating unit tests for the entire application #3) it's enabled. Selecting existing icon (SC) the menu is not enabled. DC-ing icon it is enabled. Seems like it should be enabled all the time a file is open, and if the file contains multiple XML branches, [Insert Icon] would add to that branch
And this is getting nit-picky, but the Circle-X to close a tab seems to be always in the light gray = Disabled. Maybe the active tab could use a red Circle-X, and only the inactive tabs use the current gray.
Seems like the user can add the same icon multiple times, but the ID is RDL, RDL1, etc. Maybe a check and if it's there a message: "Icon already there"?
The text was updated successfully, but these errors were encountered: