Skip to content

Commit

Permalink
5.0.0
Browse files Browse the repository at this point in the history
  • Loading branch information
@feross
feross committed Sep 27, 2016
1 parent 8762e1f commit 5daca86
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "buffer",
"description": "Node.js Buffer API, for the browser",
"version": "4.9.1",
"version": "5.0.0",
"author": {
"name": "Feross Aboukhadijeh",
"email": "feross@feross.org",
Expand Down

6 comments on commit 5daca86

@jhnns
Copy link

@jhnns jhnns commented on 5daca86 Nov 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @feross

Could you tell me where the breaking change was? Was it 8746070?

I would like to update it at webpack/node-libs-browser, but I need to evaluate the risk of a breaking change. I also noticed that browserify is still using v4.

@fanatid
Copy link
Contributor

@fanatid fanatid commented on 5daca86 Nov 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhnns Object implementation was removed 8746070

@jhnns
Copy link

@jhnns jhnns commented on 5daca86 Nov 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By referring to "object implementation" you mean this usage?

@fanatid
Copy link
Contributor

@fanatid fanatid commented on 5daca86 Nov 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.
v4.x uses Uint8Array by default and Object as shim
v5.x uses only Uint8Array and print error if TypedArrays not supported

In this package new Buffer will be marked as deprecated when node v8 will be released. (correct me if I wrong)

@jhnns
Copy link

@jhnns jhnns commented on 5daca86 Nov 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, thank you. So we'll probably stick to v4.x as default for now because many developers still need to support IE9 and IE10.

@feross
Copy link
Owner Author

@feross feross commented on 5daca86 Nov 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

Please sign in to comment.