New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cache concurrency and errors after destroy #9

Merged

feross merged 2 commits into feross:master from SocketDev:master

Apr 6, 2021

Collaborator

jhiesey commented Apr 6, 2021

Without calling this.cache.remove in put, subsequent get calls may get old values out of the cache
Calling methods after close or destroy should call the callback instead of throwing

jhiesey added 2 commits

April 5, 2021 18:31


          Fix cache consistency problem

df3f197


          Call callback when methods called after close

cb13d03

feross approved these changes

View reviewed changes

feross merged commit 092b5c5 into feross:master

Owner

feross commented Apr 6, 2021

Good catch! Published as 3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet