Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urlToOpts should include protocol to support simply getting https #1

Merged
merged 1 commit into from
Dec 29, 2014

Conversation

faeldt
Copy link

@faeldt faeldt commented Dec 29, 2014

urlToOpts is not including protocol so

get('https://myurl.com',
        function(err, getResponse) {

did not work since it was still trying http.

feross added a commit that referenced this pull request Dec 29, 2014
urlToOpts should include protocol to support simply getting https
@feross feross merged commit e9c89d7 into feross:master Dec 29, 2014
@feross
Copy link
Owner

feross commented Dec 29, 2014

Thanks for the PR!

I knew I should have added an https test along with the rest of the tests. :) Rectified in 816341f

Released as 1.1.0.

@faeldt
Copy link
Author

faeldt commented Jan 5, 2015

Np. I wasn't sure how to make a test for https so I appreciate the lesson in the linked commit. :)

@feross
Copy link
Owner

feross commented Jan 5, 2015

Yeah, it's slightly more annoying which is why I originally skipped it ;)
On Mon, Jan 5, 2015 at 3:41 AM Kristian Faeldt notifications@github.com
wrote:

Np. I wasn't sure how to make a test for https so I appreciate the lesson
in the linked commit. :)


Reply to this email directly or view it on GitHub
#1 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants