Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use subtler UI sounds #945

Merged
merged 2 commits into from Sep 22, 2016
Merged

Use subtler UI sounds #945

merged 2 commits into from Sep 22, 2016

Conversation

feross
Copy link
Member

@feross feross commented Sep 21, 2016

Fixes #858

@@ -19,19 +19,19 @@ const sounds = {
},
DELETE: {
url: 'file://' + path.join(config.STATIC_PATH, 'sound', 'delete.wav'),
volume: VOLUME
volume: VOLUME * 0.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't that mean these sounds are now louder than before? 0.4 * 0.8 > 0.15

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sounds themselves are also different @dcposch :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcposch You're right. The delete sound is unchanged, so it is now louder than before. Will fix.

Copy link
Contributor

@dcposch dcposch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcposch dcposch merged commit b8bdf65 into master Sep 22, 2016
@feross feross deleted the subtler-sounds branch September 22, 2016 21:44
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants