Add CORS parameters to web.xml #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 25, 2016 12:58
Add 3 web.xml parameters for better CORS management (crossDomainOrigin, crossDomainHeaders, and crossDomainMethods). Requires web.xml parameter enableCrossDomain to be set to true
Add null parameter checks to cross domain settings
|
@LvlAndFarm this is awesome! The only think is that it breaks backward compatibility. Would you mind to keep the default values from the previous version if a specific option is not set? It could be inside the CrossDomainParams class where you set the default values to null. Thanks man! |
Add default CORS headers to not break backward-compatibility
Most logic is now performed in the CrossDomainManager class
|
I just fixed backwards compatibility and moved most of the logic to the CrossDomainManager |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 3 web.xml parameters for better CORS management (crossDomainOrigin,
crossDomainHeaders, and crossDomainMethods). Requires web.xml parameter
enableCrossDomain to be set to true