Start working on our own version of cfg(target_has_atomic)
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My |
I forgot how `radium!` works and accidentally disabled trait production entirely on targets that have no atomics.
Macro written by Nika
|
This is driving me insane. I think I may actually bite the bullet and implement |
mystor
requested changes
Sep 16, 2020
There was a problem hiding this comment.
If we're going to need the build script anyway, as the information isn't available from the target_arch config variable, let's just do it all in the build script. No reason to have the information split across two sources.
Sorry about asking for you to switch to using macros. I didn't realize that it wasn't possible to implement without a build script >_>
Since `radium` cannot export macros capable of precise target detection, and build-script `cfg` entries are visible only to the crate to which the build script belongs, `radium` target detection must be exported some other way. The easiest way to do this is with a type alias that is conditionally set to the atom when it exists, and the cell when the atom is unavailable.
mystor
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been unhappy with our vague guessing of what atomics are available, and the #3 issue shows a target completely outside the scope of our temporary patch.
This branch uses a build script to inspect the
TARGETenvironment variable, which Cargo helpfully sets to the value of the--target ARCHflag. This will be one of the targets enumerated inrustup target list.I am running this commit through the
bitveccross-compile suite. Given that this suite is extremely slow, I expect that I will update with new targets as I discover their failures.In the meantime, I would like review on whether we think this is an appropriate solution to the problem, and how we can make the script easily accessible to users to update with their architectures as needed.