Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental QNX Support #544

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

Experimental QNX Support #544

wants to merge 34 commits into from

Conversation

Hoverbear
Copy link
Member

@Hoverbear Hoverbear commented Apr 22, 2024 •
edited

Introduces experimental QNX support.

Open Problems

  • Moving beyond QNX 7.1.0 we likely won't see Mac versions, so we should consider how to deal with that.

Hoverbear
Hoverbear commented Apr 22, 2024
View reviewed changes
.circleci/workflows.yml Outdated
@@ -159,11 +159,12 @@ jobs:
resource_class: large # 4-core
environment:
FERROCENE_HOST: x86_64-unknown-linux-gnu
FERROCENE_TARGETS: aarch64-unknown-linux-gnu,aarch64-unknown-none,thumbv7em-none-eabi,thumbv7em-none-eabihf,armv8r-none-eabihf,wasm32-unknown-unknown,armv7r-none-eabihf,armebv7r-none-eabihf
FERROCENE_TARGETS: aarch64-unknown-linux-gnu,aarch64-unknown-none,thumbv7em-none-eabi,thumbv7em-none-eabihf,armv8r-none-eabihf,wasm32-unknown-unknown,armv7r-none-eabihf,armebv7r-none-eabihf,aarch64-unknown-nto-qnx710,x86_64-pc-nto-qnx710
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting I still need to add the self-test bits but also that requires more circle.yaml changes since I need to get the QNX toolchain there, too.

@Hoverbear
Copy link
Member Author

bors try

bors-ferrocene bot added a commit that referenced this pull request Apr 22, 2024
@bors-ferrocene
Try #544:
672d145
@bors-ferrocene
Copy link
Contributor

try

Build failed:

pietroalbini
pietroalbini reviewed Apr 23, 2024
View reviewed changes
Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The permission error in CI is due to the policy don't allowing access to the whole s3://ferrocene-ci-artifacts, but just s3://ferrocene-ci-artifacts/ferrocene. I left a comment for where it should be stored.

Also, when adding the target in packages.toml please add it with the qnx subset rather than the default subset, as we want to gate access to it separately.

.circleci/workflows.yml Outdated Show resolved Hide resolved
.circleci/workflows.yml Outdated Show resolved Hide resolved
@Hoverbear Hoverbear self-assigned this Apr 25, 2024
@Hoverbear
Copy link
Member Author

bors try

1 similar comment
@Hoverbear
Copy link
Member Author

bors try

@bors-ferrocene
Copy link
Contributor

try

Already running a review

@Hoverbear
Copy link
Member Author

bors try-

@Hoverbear
Copy link
Member Author

bors try

bors-ferrocene bot added a commit that referenced this pull request Apr 26, 2024
@bors-ferrocene
Try #544:
5354901
@bors-ferrocene
Copy link
Contributor

try

Build failed:

@Hoverbear Hoverbear mentioned this pull request Apr 26, 2024
Merged
@Hoverbear
Copy link
Member Author

bors try

How about this? It should fail since you can't actually create the SSM session and thus can't get the license.

bors-ferrocene bot added a commit that referenced this pull request Apr 26, 2024
@bors-ferrocene
Try #544:
f271d3f
@bors-ferrocene
Copy link
Contributor

try

Build failed:

@Hoverbear
Copy link
Member Author

bors try

bors-ferrocene bot added a commit that referenced this pull request Apr 29, 2024
@bors-ferrocene
Try #544:
bdbf453
@bors-ferrocene
Copy link
Contributor

try

Build failed:

@Hoverbear
Copy link
Member Author

bors try

bors-ferrocene bot added a commit that referenced this pull request Apr 29, 2024
@bors-ferrocene
Try #544:
b2506b6
@bors-ferrocene
Copy link
Contributor

try

Build failed:

bors-ferrocene bot added a commit that referenced this pull request Apr 30, 2024
@bors-ferrocene @Hoverbear @pietroalbini
Merge #572 #590
da2b361 
572: Lift the repeated FERROCENE_TARGETS bits into a workflow parameter r=pietroalbini a=Hoverbear

Remove a potential footgun where we forget to self-test on a target.

This change will also be relevant to #544, since that causes our host platform support to diverge in new and interesting ways.

590: Update to the latest Sphinx version r=tshepang a=pietroalbini

This PR updates to the latest Sphinx version, which includes sphinx-doc/sphinx#11665. Along with it I also updated the rest of the dependencies, and replaced `theme.conf` with `theme.toml`.

Co-authored-by: Ana Hobden <operator@hoverbear.org>
Co-authored-by: Ana Hobden <ana.hobden@ferrous-systems.com>
Co-authored-by: Pietro Albini <pietro.albini@ferrous-systems.com>
@Hoverbear
Copy link
Member Author

bors try

bors-ferrocene bot added a commit that referenced this pull request Apr 30, 2024
@bors-ferrocene
Try #544:
5caf836
@bors-ferrocene
Copy link
Contributor

try

Build failed:

@Hoverbear
Copy link
Member Author

bors try

bors-ferrocene bot added a commit that referenced this pull request Jun 18, 2024
@bors-ferrocene
Try #544:
8e6e08c
@bors-ferrocene
Copy link
Contributor

try

Build failed:

@Hoverbear
Copy link
Member Author

I updated our deployment image to remove armv7le support and the docs. That should reduce the number of files Windows struggles with.

@Hoverbear
Copy link
Member Author

bors try

bors-ferrocene bot added a commit that referenced this pull request Jun 19, 2024
@bors-ferrocene
Try #544:
382c047
@bors-ferrocene
Copy link
Contributor

try

Build failed:

@Hoverbear
Copy link
Member Author

bors try

@Hoverbear Hoverbear closed this Jun 19, 2024
@Hoverbear Hoverbear reopened this Jun 19, 2024
bors-ferrocene bot added a commit that referenced this pull request Jun 19, 2024
@bors-ferrocene
Try #544:
9ab3379
@Hoverbear
Copy link
Member Author

bors try

@bors-ferrocene
Copy link
Contributor

try

Already running a review

@bors-ferrocene
Copy link
Contributor

try

Timed out.

2 similar comments
@bors-ferrocene
Copy link
Contributor

try

Timed out.

@bors-ferrocene
Copy link
Contributor

try

Timed out.

@Hoverbear
Copy link
Member Author

I removed the QNX windows self-test and updated the docs to note this for now. I'll circle back around to try to fix 43+ minute tarball unpack on Windows. I'm not sure how to resolve it as it seems to be a simple case of "No IOPS"

@Hoverbear
Copy link
Member Author

bors try

bors-ferrocene bot added a commit that referenced this pull request Jun 20, 2024
@bors-ferrocene
Try #544:
b641ee5
@bors-ferrocene
Copy link
Contributor

try

Build succeeded:

  • full

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietroalbini pietroalbini Awaiting requested review from pietroalbini

Assignees

@Hoverbear Hoverbear

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hoverbear @pietroalbini