Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lift the repeated FERROCENE_TARGETS bits into a workflow parameter #572

Merged
merged 5 commits into from
Apr 30, 2024
Merged

Lift the repeated FERROCENE_TARGETS bits into a workflow parameter #572

merged 5 commits into from
Apr 30, 2024

Conversation

Hoverbear
Copy link
Member

@Hoverbear Hoverbear commented Apr 26, 2024 •
edited
Loading

Remove a potential footgun where we forget to self-test on a target.

This change will also be relevant to #544, since that causes our host platform support to diverge in new and interesting ways.

@Hoverbear Hoverbear self-assigned this Apr 26, 2024
@Hoverbear
Copy link
Member Author

bors try

@Hoverbear
Copy link
Member Author

bors try

@bors-ferrocene
Copy link
Contributor

try

Already running a review

bors-ferrocene bot added a commit that referenced this pull request Apr 26, 2024
@bors-ferrocene
Try #572:
eb90cb5
@Hoverbear
Copy link
Member Author

bors try-

@Hoverbear
Copy link
Member Author

bors try

bors-ferrocene bot added a commit that referenced this pull request Apr 26, 2024
@bors-ferrocene
Try #572:
786236d
@Hoverbear
Copy link
Member Author

Whoops xD

@bors-ferrocene
Copy link
Contributor

try

Build succeeded:

@Hoverbear
Copy link
Member Author

In light of #544 introducing a Linux-only target I went ahead and abstracted this a bit further to have OS specific parameters.

@Hoverbear
Copy link
Member Author

bors try

I think this will be more robust moving forward and should play nicely with #571 and #544

@Hoverbear Hoverbear force-pushed the hoverbear/cross-compile-targets-as-parameters branch from 5ea426b to ad83cba Compare April 26, 2024 19:22
@Hoverbear
Copy link
Member Author

bors try

@bors-ferrocene
Copy link
Contributor

try

Already running a review

@Hoverbear
Copy link
Member Author

bors try-

@Hoverbear
Copy link
Member Author

bors try

bors-ferrocene bot added a commit that referenced this pull request Apr 28, 2024
@bors-ferrocene
Try #572:
d4a7a2c
@bors-ferrocene
Copy link
Contributor

try

Build failed:

  • full

@Hoverbear
Copy link
Member Author

bors try

bors-ferrocene bot added a commit that referenced this pull request Apr 29, 2024
@bors-ferrocene
Try #572:
6c75c26
@bors-ferrocene
Copy link
Contributor

try

Build succeeded:

pietroalbini
pietroalbini approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors-ferrocene
Copy link
Contributor

Build succeeded:

  • full

@bors-ferrocene bors-ferrocene bot merged commit da2b361 into main Apr 30, 2024
3 checks passed
@bors-ferrocene bors-ferrocene bot deleted the hoverbear/cross-compile-targets-as-parameters branch April 30, 2024 11:45
@github-actions github-actions bot added the backport:maybe PR candidate for backport label Apr 30, 2024
@github-actions github-actions bot removed the backport:maybe PR candidate for backport label Jul 2, 2024
@Hoverbear Hoverbear added the backport:manual PR requiring manual intervention to backport label Jul 2, 2024
Hoverbear added a commit that referenced this pull request Jul 2, 2024
@Hoverbear
Fixup logic issue
dcdafb3 
Ferrocene-backport-of: #572
@Hoverbear Hoverbear removed backport:manual PR requiring manual intervention to backport backport:1.79 labels Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietroalbini pietroalbini pietroalbini approved these changes

Assignees

@Hoverbear Hoverbear

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hoverbear @pietroalbini