Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defective OBERON export of Alternatives #1146

Closed
codemanyak opened this issue Mar 18, 2024 · 1 comment
Closed

Defective OBERON export of Alternatives #1146

codemanyak opened this issue Mar 18, 2024 · 1 comment
Assignees
@codemanyak
Labels
bug enhancement Fixed Implemented (though possibly still not delivered)
Milestone
Release 3.33

Comments

@codemanyak
Copy link
Collaborator

codemanyak commented Mar 18, 2024 •
edited

Structorizer generates wrong code for Alternatives with more than a TRUE branch:
grafik

The END is only to close the entire IF statement and must not be inserted if an ELSE (or ELSIF) follows the THEN branch. Hence, it is wrongy placed in the code.

On this occasion, OBERON export should be made smarter with respect to IF ELSE IF chains, e.g. for the following diagram, an ELSIF should have been used instead of the statement nesting (blue mark):
grafik
@codemanyak codemanyak added the bug label Mar 18, 2024
@codemanyak codemanyak added this to the Release 3.33 milestone Mar 18, 2024
@codemanyak codemanyak self-assigned this Mar 18, 2024
@codemanyak
Copy link
Collaborator Author

Bug was fixed:
grafik

@codemanyak codemanyak added the Fixed Implemented (though possibly still not delivered) label Mar 18, 2024
@codemanyak codemanyak mentioned this issue Mar 18, 2024
Merged
codemanyak added a commit that referenced this issue Mar 19, 2024
@codemanyak
#1146 improved (line mapping for code preview)
a2164fc
codemanyak added a commit that referenced this issue Mar 19, 2024
@codemanyak
Code for #1146 refurbished for more clarity
5d847d7
@fesch fesch closed this as completed in e584c04 Mar 19, 2024
@codemanyak codemanyak mentioned this issue Mar 19, 2024
Closed
codemanyak added a commit that referenced this issue Mar 19, 2024
@codemanyak
Fixes #1148, rectifies #1146 w.r.t. disabling
067e307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codemanyak codemanyak

Labels
bug enhancement Fixed Implemented (though possibly still not delivered)
Projects
None yet
Milestone
Release 3.33
Development

No branches or pull requests
1 participant
@codemanyak