Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional buttons in header #762

Merged

Conversation

RemDelaporteMathurin
Copy link
Collaborator

Proposed changes

This PR fixes #760

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.51%. Comparing base (fdfcb17) to head (51fea45).
Report is 284 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #762      +/-   ##
==========================================
+ Coverage   99.48%   99.51%   +0.02%     
==========================================
  Files          58       58              
  Lines        2350     2478     +128     
==========================================
+ Hits         2338     2466     +128     
  Misses         12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemDelaporteMathurin
Copy link
Collaborator Author

The result isn't ideal as it adds the icon button in the sidebar and not the header.

I opened an issue to see if it is possible with the sphinx-book-theme

@RemDelaporteMathurin RemDelaporteMathurin changed the title Discourse button in conf Additional buttons in header Jun 3, 2024
@RemDelaporteMathurin RemDelaporteMathurin merged commit 1623d18 into festim-dev:main Jun 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discourse forum in documentation as button
1 participant