Fix some issues

Authorization/Authorizer.cs

@@ -148,7 +148,9 @@ public static bool IsAuthorized(this IAuthorizable authorizable, string permissi
                 break;
             case Member member:
                 permissionsSets.AddRange(member.Groups.OrderBy(_ => _.SortValue).Select(_ => _.Permissions));
-                permissionsSets.AddRange(Pool.Server.Groups.FindAll(@group => @group.SortValue <= member.Groups.Select(_ => _.SortValue).Min()).OrderBy(_ => _.SortValue).Select(_ => _.Permissions));
+                if (member.Groups.Count > 0) {
+                    permissionsSets.AddRange(Pool.Server.Groups.FindAll(@group => @group.SortValue <= member.Groups.Select(_ => _.SortValue).Min()).OrderBy(_ => _.SortValue).Select(_ => _.Permissions));
+                }
 
                 //if (member.ActiveChannel != null && member.ActiveChannel.MemberPermissions.ContainsKey(member.InternalId)) {
                 //    permissionsSets.Add(member.ActiveChannel.MemberPermissions[member.InternalId]);
@@ -190,7 +192,9 @@ public static Dictionary<string, Permission> GetAllPermissons(this IAuthorizable
                 break;
             case Member member:
                 permissionsSets.AddRange(member.Groups.OrderBy(_ => _.SortValue).Select(_ => _.Permissions));
-                permissionsSets.AddRange(Pool.Server.Groups.FindAll(@group => @group.SortValue < member.Groups.Select(_ => _.SortValue).Min()).OrderBy(_ => _.SortValue).Select(_ => _.Permissions));
+                if (member.Groups.Count > 0) {
+                    permissionsSets.AddRange(Pool.Server.Groups.FindAll(@group => @group.SortValue < member.Groups.Select(_ => _.SortValue).Min()).OrderBy(_ => _.SortValue).Select(_ => _.Permissions));
+                }
 
                 //if (member.ActiveChannel != null && member.ActiveChannel.MemberPermissions.ContainsKey(member.InternalId)) {
                 //    permissionsSets.Add(member.ActiveChannel.MemberPermissions[member.InternalId]);

Communication/Packages/MessagePackageContent.cs

@@ -1,5 +1,6 @@
 using System;
 using Neo.Core.Config;
+using Neo.Core.Management;
 using Neo.Core.Shared;
 
 namespace Neo.Core.Communication.Packages
@@ -89,7 +90,7 @@ public static MessagePackageContent GetSentMessage(Guid senderId, Identity ident
         /// <param name="channelId">The internal id of the channel this message belongs to.</param>
         /// <returns>Returns the created content.</returns>
         public static MessagePackageContent GetSystemMessage(string message, Guid channelId) {
-            return new MessagePackageContent(Guid.Empty, ConfigManager.Instance.Values.RootIdentity, message, DateTime.Now, "system", channelId);
+            return new MessagePackageContent(Guid.Empty, UserManager.GetRoot().Identity, message, DateTime.Now, "system", channelId);
         }
     }
 }

Config/ConfigValues.cs

@@ -23,22 +23,6 @@ public class ConfigValues
         [EditableProperty("Registrierung zulassen")]
         public bool RegistrationAllowed { get; set; } = true;
 
-        /// <summary>
-        ///     The identity for the root account.
-        /// </summary>
-        public Identity RootIdentity { get; set; } = new Identity { Id = "neo", Name = "Neo" };
-
-        /// <summary>
-        ///     The password for the root account.
-        /// </summary>
-        public byte[] RootPassword { get; set; } = NeoCryptoProvider.Instance.Sha512ComputeHash("LT6SUK7JBELX3UAL");
-
-        /// <summary>
-        ///     The key size used for RSA encryption.
-        /// </summary>
-        [Obsolete]
-        public int RSAKeySize { get; set; } = 4096;
-
         /// <summary>
         ///     The address the server is listening to.
         /// </summary>

Management/UserManager.cs

@@ -25,7 +25,10 @@ public static Account GetRoot() {
         /// </summary>
         public static void RefreshAccounts() {
             var accounts = JsonConvert.DeserializeObject<List<Account>>(JsonConvert.SerializeObject(Pool.Server.Accounts));
-            accounts.ForEach(_ => _.Password = null);
+            accounts.ForEach(_ => {
+                _.Password = null;
+                _.Identity.AvatarFileExtension = Pool.Server.AvatarServerAvailable ? _.Identity.AvatarFileExtension : "";
+            });
 
             Target.All.SendPackage(new Package(PackageType.AccountListUpdate, accounts));
         }

Networking/BaseServer.cs

@@ -10,6 +10,7 @@
 using Neo.Core.Communication;
 using Neo.Core.Communication.Packages;
 using Neo.Core.Config;
+using Neo.Core.Cryptography;
 using Neo.Core.Database;
 using Neo.Core.Extensibility;
 using Neo.Core.Extensibility.Events;
@@ -65,6 +66,8 @@ public abstract class BaseServer
             { "neo.moderate.kick", "Benutzer kicken" }
         };
 
+        public bool AvatarServerAvailable { get; set; } = true;
+
         public DataProvider DataProvider { get; set; }
 
         // ReSharper disable once InconsistentNaming
@@ -121,15 +124,20 @@ public void Initialize(string configPath, string dataDirectoryPath, string plugi
                         { "neo.usertype", "root" }
                     },
                     Email = "root@internal.neo",
-                    Identity = ConfigManager.Instance.Values.RootIdentity,
-                    Password = ConfigManager.Instance.Values.RootPassword,
+                    Identity = new Identity {
+                        Id = "neo",
+                        Name = "Neo"
+                    },
+                    Password = NeoCryptoProvider.Instance.Sha512ComputeHash("alpine"),
                     Permissions = new Dictionary<string, Permission> {
                         { "*", Permission.Allow }
                     }
                 });
                 Logger.Instance.Log(LogLevel.Debug, "No root account existed. Default root account created");
             }
 
+            Channels.ForEach(_ => _.MemberIds.Remove(UserManager.GetRoot().InternalId));
+
             // Create main channel
             if (ChannelManager.GetMainChannel() == null) {
                 Channels.Insert(0, new Channel {
@@ -156,7 +164,6 @@ public void Initialize(string configPath, string dataDirectoryPath, string plugi
                     Id = "admins",
                     Name = "Administratoren",
                     Permissions = new Dictionary<string, Permission> {
-                        // TODO: Fix default admin group rights
                         { "neo.*", Permission.Allow }
                     },
                     SortValue = 999
@@ -168,35 +175,34 @@ public void Initialize(string configPath, string dataDirectoryPath, string plugi
             if (GroupManager.GetGuestGroup() == null) {
                 Groups.Add(new Group {
                     Attributes = new Dictionary<string, object> {
-                        { "neo.grouptype", "user" }
+                        { "neo.grouptype", "guest" }
                     },
-                    Id = "users",
-                    Name = "Benutzer",
+                    Id = "guests",
+                    Name = "Gäste",
                     Permissions = new Dictionary<string, Permission> {
-                        // TODO: Fix default user group rights
-                        { "neo.*", Permission.Allow }
+                        { "neo.channel.join.$", Permission.Allow },
+                        { "neo.global.*", Permission.Allow }
                     },
-                    SortValue = 1
+                    SortValue = 0
                 });
                 DataProvider.Save();
-                Logger.Instance.Log(LogLevel.Debug, "No user group existed. Default user group created");
+                Logger.Instance.Log(LogLevel.Debug, "No guest group existed. Default guest group created");
             }
 
-            if (GroupManager.GetGuestGroup() == null) {
+            if (GroupManager.GetUserGroup() == null) {
                 Groups.Add(new Group {
                     Attributes = new Dictionary<string, object> {
-                        { "neo.grouptype", "guest" }
+                        { "neo.grouptype", "user" }
                     },
-                    Id = "guests",
-                    Name = "Gäste",
+                    Id = "users",
+                    Name = "Benutzer",
                     Permissions = new Dictionary<string, Permission> {
-                        // TODO: Fix default guest group rights
-                        { "neo.*", Permission.Allow }
+                        { "neo.channel.create", Permission.Allow }
                     },
-                    SortValue = 0
+                    SortValue = 1
                 });
                 DataProvider.Save();
-                Logger.Instance.Log(LogLevel.Debug, "No guest group existed. Default guest group created");
+                Logger.Instance.Log(LogLevel.Debug, "No user group existed. Default user group created");
             }
 
             foreach (var pluginFile in new DirectoryInfo(pluginDirectoryPath).EnumerateFiles("*.dll")) {

Networking/HttpServer.cs

@@ -143,6 +143,7 @@ private void Listen(object obj) {
                 // TODO: Improve Log Messages
                 Logger.Instance.Log(LogLevel.Error, "HttpServer couldn't be started. Make sure you are running in high priviledged mode.");
                 Logger.Instance.Log(LogLevel.Error, "Error starting HttpServer on :" + Port + ". Avatars won't be available.");
+                Pool.Server.AvatarServerAvailable = false;
                 return;
             }
 

Shared/Channel.cs

@@ -35,12 +35,14 @@ public class Channel : IAttributable
         /// <summary>
         ///     Contains the internal ids of all groups that are not allowed to enter this <see cref="Channel"/>.
         /// </summary>
+        [JsonIgnore]
         [Obsolete]
         public List<Guid> BlacklistedGroupIds { get; set; } = new List<Guid>();
 
         /// <summary>
         ///     Contains the internal ids of all users who are not allowed to enter this <see cref="Channel"/>.
         /// </summary>
+        [JsonIgnore]
         [Obsolete]
         public List<Guid> BlacklistedUserIds { get; set; } = new List<Guid>();
 
@@ -78,6 +80,7 @@ public class Channel : IAttributable
         /// <summary>
         ///     The permissions assigned to the individual members of this <see cref="Channel"/>.
         /// </summary>
+        [JsonIgnore]
         [Obsolete]
         public Dictionary<Guid, Dictionary<string, Permission>> MemberPermissions { get; set; } = new Dictionary<Guid, Dictionary<string, Permission>>();
 
@@ -110,30 +113,35 @@ public class Channel : IAttributable
         /// <summary>
         ///     The status message of this <see cref="Channel"/>.
         /// </summary>
+        [JsonIgnore]
         [Obsolete]
         public string StatusMessage { get; set; }
 
         /// <summary>
         ///     Contains the internal ids of all groups that are allowed to join this <see cref="Channel"/>.
         /// </summary>
+        [JsonIgnore]
         [Obsolete]
         public List<Guid> WhitelistedGroupIds { get; set; } = new List<Guid>();
 
         /// <summary>
         ///     Contains the internal ids of all users who are allowed to join this <see cref="Channel"/>.
         /// </summary>
+        [JsonIgnore]
         [Obsolete]
         public List<Guid> WhitelistedUserIds { get; set; } = new List<Guid>();
 
         /// <summary>
         ///     Contains the internal ids of all groups that are allowed to see this <see cref="Channel"/>.
         /// </summary>
+        [JsonIgnore]
         [Obsolete]
         public List<Guid> VisibleToGroupIds { get; set; } = new List<Guid>();
 
         /// <summary>
         ///     Contains the internal ids of all users who are allowed to see this <see cref="Channel"/>.
         /// </summary>
+        [JsonIgnore]
         [Obsolete]
         public List<Guid> VisibleToUserIds { get; set; } = new List<Guid>();