Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stargate #2613

Merged
merged 69 commits into from
Sep 7, 2021
Merged

Stargate #2613

merged 69 commits into from
Sep 7, 2021

Conversation

5A11
Copy link
Member

@5A11 5A11 commented Sep 6, 2021

This PR adds Stargate support for fetchai ledger.

Types of changes

What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes and CI passes too
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@codecov-commenter
Copy link

Codecov Report

Merging #2613 (3ded31f) into develop (3a5ddca) will increase coverage by 0.06%.
The diff coverage is 99.03%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2613      +/-   ##
===========================================
+ Coverage    99.82%   99.89%   +0.06%     
===========================================
  Files          511      520       +9     
  Lines        35206    35682     +476     
===========================================
+ Hits         35146    35645     +499     
+ Misses          60       37      -23     
Flag Coverage Δ
unittests 99.89% <99.03%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/fetchai/skills/http_echo/handlers.py 100.00% <ø> (ø)
packages/fetchai/skills/simple_oracle/handlers.py 100.00% <ø> (ø)
...ages/fetchai/skills/error_test_skill/behaviours.py 60.00% <60.00%> (ø)
aea/crypto/ledger_apis.py 100.00% <100.00%> (ø)
aea/helpers/serializers.py 100.00% <100.00%> (ø)
aea/manager/manager.py 100.00% <100.00%> (ø)
aea/manager/utils.py 100.00% <100.00%> (ø)
aea/test_tools/test_contract.py 98.78% <100.00%> (+4.18%) ⬆️
...ages/fetchai/connections/http_server/connection.py 100.00% <100.00%> (ø)
...kages/fetchai/connections/p2p_libp2p/connection.py 100.00% <100.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a5ddca...3ded31f. Read the comment docs.

@@ -35,6 +35,6 @@ type: connection
config:
ledger_apis:
fetchai:
address: https://rest-beaconworld.fetch.ai:443
Copy link
Contributor

@jrriehl jrriehl Sep 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check on this, but I believe that Stargateworld does not have a random beacon, in which case this agent and skill would not work.

Copy link
Contributor

@jrriehl jrriehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@DavidMinarsch DavidMinarsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was that the switch to stargate finally resolves the test failures. However, I observe quite a few and it is harder to see now where they come from. I suggest @solarw has a look to address them so that we have a green test run before we merge.

@5A11
Copy link
Member Author

5A11 commented Sep 7, 2021

The idea was that the switch to stargate finally resolves the test failures. However, I observe quite a few and it is harder to see now where they come from. I suggest @solarw has a look to address them so that we have a green test run before we merge.

We have addressed all Stargate related failures. There is none in this PR.
The failures are either:
a) public DHT related: waiting for prod to be synced with latest ACN changes.
b) multi aea manager related: @solarw is looking into those.
c) odd failures here and there: also @solarw is looking into those.

@5A11 5A11 merged commit b0802b6 into develop Sep 7, 2021
@DavidMinarsch DavidMinarsch deleted the stargate branch October 15, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants